posix: Pass -Werror to the compiler driver for link invocations as well.

posix: Pass -Werror to the compiler driver for link invocations as well.

With this, we would've caught https://codereview.chromium.org/2520453002/
before landing that clang roll.

BUG=665063
Committed: https://crrev.com/e9dcf4f53596206b44620d2aeecfbfc372f58920
Cr-Commit-Position: refs/heads/master@{#434187}

[Nico, 2016-11-22 22:53:21]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 23:02:34]

thakis@chromium.org changed reviewers:
+ rnk@chromium.org

[Nico, 2016-11-22 23:02:35]

Nice catch :-)

[commit-bot: I haz the power, 2016-11-22 23:16:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:16:02]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Reid Kleckner, 2016-11-22 23:34:12]

Looks like you found some Android warnings:

[6104/18489] SOLINK ./libcast_media_1.0_android.so
FAILED: libcast_media_1.0_android.so libcast_media_1.0_android.so.TOC
lib.unstripped/libcast_media_1.0_android.so 
python ...
clang: error: argument unused during compilation: '-static-libstdc++'
[-Werror,-Wunused-command-line-argument]
clang: error: argument unused during compilation: '-static-libgcc'
[-Werror,-Wunused-command-line-argument]

[Nico, 2016-11-23 00:54:38]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 00:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-23 00:55:22]

Hooray!

I disabled -Werror in ldflags for asan and cast builds for now.

[commit-bot: I haz the power, 2016-11-23 02:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:10:46]

Dry run: This issue passed the CQ dry run.

[Reid Kleckner, 2016-11-23 16:42:59]

lgtm

[Nico, 2016-11-23 16:45:03]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-23 16:45:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 16:53:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479919503275930,
"parent_rev": "3767e4740a0c777fcc9f39d38949263618b35db6", "commit_rev":
"dde3a6b93bb9f0ba402c1a752757ff5cd8615a75"}

[commit-bot: I haz the power, 2016-11-23 16:54:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 16:57:07]

Description was changed from

==========
posix: Pass -Werror to the compiler driver for link invocations as well.

With this, we would've caught https://codereview.chromium.org/2520453002/
before landing that clang roll.

BUG=665063
==========

to

==========
posix: Pass -Werror to the compiler driver for link invocations as well.

With this, we would've caught https://codereview.chromium.org/2520453002/
before landing that clang roll.

BUG=665063

Committed: https://crrev.com/e9dcf4f53596206b44620d2aeecfbfc372f58920
Cr-Commit-Position: refs/heads/master@{#434187}
==========

[commit-bot: I haz the power, 2016-11-23 16:57:08]

Patchset 2 (id:??) landed as
https://crrev.com/e9dcf4f53596206b44620d2aeecfbfc372f58920
Cr-Commit-Position: refs/heads/master@{#434187}