Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2521913004: Deoptimize Search - request a new resolved unit for local search. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deoptimize Search - request a new resolved unit for local search. It seems to me that it would be easier to integrate if we keep the same search technique - search for Element references. I think any saving can be only for local elements search. If it turns out to be expensive, we could add priority results caching in the driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4fea218f7763d5864d592fd40884227d0ecbc01a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -77 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/search.dart View 3 chunks +30 lines, -31 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 3 chunks +40 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 3 chunks +0 lines, -37 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 7 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-22 18:26:16 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-22 18:29:46 UTC) #2
scheglov
4 years, 1 month ago (2016-11-22 18:34:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4fea218f7763d5864d592fd40884227d0ecbc01a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698