Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2521883003: Enabled VR Shell unittests on main waterfall (Closed)

Created:
4 years, 1 month ago by bsheedy
Modified:
4 years ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled VR Shell unittests on main waterfall Changes the VR Shell unittests to compile when WebVR is enabled and enables them on chromium.android builders. BUG=667964 Committed: https://crrev.com/5750756522296b2a9a08009d8d2cc90db3b88f56 Cr-Commit-Position: refs/heads/master@{#434843}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1 line) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.android.json View 6 chunks +103 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
bsheedy
bshe@chromium.org: Please see change to BUILD file stip@chromium.org: Please see changes to .json file
4 years, 1 month ago (2016-11-23 00:48:30 UTC) #3
bshe
On 2016/11/23 00:48:30, bsheedy wrote: > mailto:bshe@chromium.org: Please see change to BUILD file > > ...
4 years ago (2016-11-23 14:27:52 UTC) #4
ghost stip (do not use)
https://codereview.chromium.org/2521883003/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2521883003/diff/1/testing/buildbot/chromium.android.json#newcode2498 testing/buildbot/chromium.android.json:2498: "device_os": "KTU84P", we have a bit of a capacity ...
4 years ago (2016-11-28 21:56:28 UTC) #6
bsheedy
On 2016/11/28 21:56:28, stip wrote: > https://codereview.chromium.org/2521883003/diff/1/testing/buildbot/chromium.android.json > File testing/buildbot/chromium.android.json (right): > > https://codereview.chromium.org/2521883003/diff/1/testing/buildbot/chromium.android.json#newcode2498 > ...
4 years ago (2016-11-28 21:58:54 UTC) #7
ghost stip (do not use)
lgtm
4 years ago (2016-11-29 00:56:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521883003/1
4 years ago (2016-11-29 00:58:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:48:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 02:53:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5750756522296b2a9a08009d8d2cc90db3b88f56
Cr-Commit-Position: refs/heads/master@{#434843}

Powered by Google App Engine
This is Rietveld 408576698