Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/helpers.js

Issue 2521793004: service worker: Persist NavigationPreloadState (Closed)
Patch Set: add test and comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/get-state.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 function expect_state(state, enabled, header, desc) {
horo 2016/11/24 08:59:46 Nit: This method should have a more specific name.
falken 2016/11/24 13:36:24 Done.
2 assert_equals(Object.keys(state).length, 2, desc + ': # of keys');
3 assert_equals(state.enabled, enabled, desc + ': enabled');
4 assert_equals(state.headerValue, header, desc + ': header');
5 }
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/get-state.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698