service worker: Persist NavigationPreloadState

service worker: Persist NavigationPreloadState

This writes NPS to storage. NPS is included as a field in
ServiceWorkerRegistration. I was previously considering how to handle writing
to storage before an active worker exists (and hence before a SWRegistration
exists in storage), but the spec discussion is converging on requiring an
active worker so this should be sufficient.

BUG=649558
Committed: https://crrev.com/92636463938f6dafce67b97a884d2cb11f27a2cb
Cr-Commit-Position: refs/heads/master@{#434411}

[falken, 2016-11-22 05:33:34]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[falken, 2016-11-22 05:33:45]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2016-11-22 05:33:46]

ptal

[commit-bot: I haz the power, 2016-11-22 05:33:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 08:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 08:37:58]

Dry run: This issue passed the CQ dry run.

[horo, 2016-11-22 14:28:23]

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host.cc:713: if
(!registration->active_version()) {
Please add comment about this behavior and a link to the discussion.
And add TODO to remove it when the spec discussion is finished.

And please add layout test for this failure.

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host.cc:850: if
(!registration->active_version()) {
ditto

[falken, 2016-11-24 07:06:30]

Patchset #2 (id:20001) has been deleted

[falken, 2016-11-24 07:10:00]

Thanks.

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host.cc:713: if
(!registration->active_version()) {
On 2016/11/22 14:28:23, horo wrote:
> Please add comment about this behavior and a link to the discussion.
> And add TODO to remove it when the spec discussion is finished.
> 
> And please add layout test for this failure.

Done.

https://codereview.chromium.org/2521793004/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_dispatcher_host.cc:850: if
(!registration->active_version()) {
On 2016/11/22 14:28:23, horo wrote:
> ditto

Done.

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js
(right):

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/wait-for-activate-worker.js:7:
function expect_rejection(promise) {
Ideally I'd use the harness's promise_rejects but it requires a |test| object.
Not sure how to create one here: promise_test causes the code to run async which
means we can't use message and install event handlers.

[falken, 2016-11-24 08:25:10]

The CQ bit was checked by falken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 08:25:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-11-24 08:59:46]

lgtm with a nit.

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/helpers.js
(right):

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/helpers.js:1:
function expect_state(state, enabled, header, desc) {
Nit: This method should have a more specific name.
expect_navigation_preload_state()?

[commit-bot: I haz the power, 2016-11-24 10:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 10:26:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[falken, 2016-11-24 13:36:24]

Thanks.

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/helpers.js
(right):

https://codereview.chromium.org/2521793004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/resources/helpers.js:1:
function expect_state(state, enabled, header, desc) {
On 2016/11/24 08:59:46, horo wrote:
> Nit: This method should have a more specific name.
> expect_navigation_preload_state()? 

Done.

[falken, 2016-11-24 13:36:31]

The CQ bit was checked by falken@chromium.org

[falken, 2016-11-24 13:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2521793004/#ps60001
(title: "expect_ name")

[commit-bot: I haz the power, 2016-11-24 13:37:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 15:27:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:27:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[falken, 2016-11-24 22:39:53]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2016-11-24 22:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 00:05:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480027193384130,
"parent_rev": "4d4d62e9d90056cbc2a580481d381daa8d563b9a", "commit_rev":
"83376e0f401508b795214a3c2ef1b0a7468b98a7"}

[commit-bot: I haz the power, 2016-11-25 00:06:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-25 00:09:06]

Description was changed from

==========
service worker: Persist NavigationPreloadState

This writes NPS to storage. NPS is included as a field in
ServiceWorkerRegistration. I was previously considering how to handle writing
to storage before an active worker exists (and hence before a SWRegistration
exists in storage), but the spec discussion is converging on requiring an
active worker so this should be sufficient.

BUG=649558
==========

to

==========
service worker: Persist NavigationPreloadState

This writes NPS to storage. NPS is included as a field in
ServiceWorkerRegistration. I was previously considering how to handle writing
to storage before an active worker exists (and hence before a SWRegistration
exists in storage), but the spec discussion is converging on requiring an
active worker so this should be sufficient.

BUG=649558

Committed: https://crrev.com/92636463938f6dafce67b97a884d2cb11f27a2cb
Cr-Commit-Position: refs/heads/master@{#434411}
==========

[commit-bot: I haz the power, 2016-11-25 00:09:07]

Patchset 3 (id:??) landed as
https://crrev.com/92636463938f6dafce67b97a884d2cb11f27a2cb
Cr-Commit-Position: refs/heads/master@{#434411}