Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: chrome/browser/ui/browser.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Fix android compile. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 6cdff54b676fd12f703c9128fc8f9c640a2aca19..bc9d602b216cea209cc5206c22c30f871b3e1069 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -612,10 +612,12 @@ class Browser : public TabStripModelObserver,
void ShowRepostFormWarningDialog(content::WebContents* source) override;
bool ShouldCreateWebContents(
content::WebContents* web_contents,
+ content::SiteInstance* source_site_instance,
int32_t route_id,
int32_t main_frame_route_id,
int32_t main_frame_widget_route_id,
WindowContainerType window_container_type,
+ const GURL& opener_url,
const std::string& frame_name,
const GURL& target_url,
const std::string& partition_id,
@@ -857,10 +859,11 @@ class Browser : public TabStripModelObserver,
// Creates a BackgroundContents if appropriate; return true if one was
// created.
bool MaybeCreateBackgroundContents(
+ content::SiteInstance* site_instance,
Charlie Reis 2016/11/23 06:59:48 nit: Maybe this should be source_site_instance lik
ncarter (slow) 2016/11/24 00:00:05 Done.
+ const GURL& opener_url,
int32_t route_id,
int32_t main_frame_route_id,
int32_t main_frame_widget_route_id,
- content::WebContents* opener_web_contents,
const std::string& frame_name,
const GURL& target_url,
const std::string& partition_id,

Powered by Google App Engine
This is Rietveld 408576698