Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 319daf9e93ac0e6e1c635641741de2db525e2850..6b951ce81ca35a835993adacfc146e92250b24fa 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2066,9 +2066,10 @@ void WebContentsImpl::CreateNewWindow(
if (delegate_ &&
!delegate_->ShouldCreateWebContents(
- this, route_id, main_frame_route_id, main_frame_widget_route_id,
- params.window_container_type, params.frame_name, params.target_url,
- partition_id, session_storage_namespace)) {
+ this, source_site_instance, route_id, main_frame_route_id,
+ main_frame_widget_route_id, params.window_container_type,
+ params.opener_url, params.frame_name, params.target_url, partition_id,
+ session_storage_namespace)) {
if (route_id != MSG_ROUTING_NONE &&
!RenderViewHost::FromID(render_process_id, route_id)) {
// If the embedder didn't create a WebContents for this route, we need to

Powered by Google App Engine
This is Rietveld 408576698