Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
diff --git a/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc b/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
index 992ad4c00dcc4fe24d93dcbe0b9e1f7b30339f27..f430467532ffbd64c340bfbce5f00a5b59921bf7 100644
--- a/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
+++ b/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
@@ -96,11 +96,13 @@ TEST_F(BackgroundLoaderContentsTest, CannotDownload) {
TEST_F(BackgroundLoaderContentsTest, ShouldNotCreateWebContents) {
ASSERT_FALSE(contents()->ShouldCreateWebContents(
- nullptr /* contents */, 0 /* route_id */, 0 /* main_frame_route_id */,
+ nullptr /* contents */, nullptr /* source_site_instance */,
+ 0 /* route_id */, 0 /* main_frame_route_id */,
0 /* main_frame_widget_route_id */,
WINDOW_CONTAINER_TYPE_NORMAL /* window_container_type */,
- "foo" /* frame_name */, GURL::EmptyGURL() /* target_url */,
- "bar" /* partition_id */, nullptr /* session_storage_namespace */));
+ GURL() /* opener_url */, "foo" /* frame_name */,
+ GURL::EmptyGURL() /* target_url */, "bar" /* partition_id */,
+ nullptr /* session_storage_namespace */));
}
TEST_F(BackgroundLoaderContentsTest, ShouldNotAddNewContents) {

Powered by Google App Engine
This is Rietveld 408576698