chrome/browser/extensions/api/tab_capture/offscreen_tab.h - Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/offscreen_tab.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)

Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tab_capture/offscreen_tab.h

diff --git a/chrome/browser/extensions/api/tab_capture/offscreen_tab.h b/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

index e6393192a0668b49b68e782e1e2dc37c19eed521..992160d53650b4601b0a2fbc4b5d3f7e1268b1fd 100644

--- a/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

+++ b/chrome/browser/extensions/api/tab_capture/offscreen_tab.h

@@ -140,11 +140,13 @@ class OffscreenTab : protected content::WebContentsDelegate,

const content::DropData& data,

blink::WebDragOperationsMask operations_allowed) final;

bool ShouldCreateWebContents(

- content::WebContents* contents,

+ content::WebContents* web_contents,

+ content::SiteInstance* source_site_instance,

int32_t route_id,

int32_t main_frame_route_id,

int32_t main_frame_widget_route_id,

WindowContainerType window_container_type,

+ const GURL& opener_url,

const std::string& frame_name,

const GURL& target_url,

const std::string& partition_id,