Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Fix android compile. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/web_contents_delegate_android/web_contents_delegate_android .h" 5 #include "components/web_contents_delegate_android/web_contents_delegate_android .h"
6 6
7 #include <android/keycodes.h> 7 #include <android/keycodes.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 void WebContentsDelegateAndroid::RendererResponsive(WebContents* source) { 178 void WebContentsDelegateAndroid::RendererResponsive(WebContents* source) {
179 JNIEnv* env = AttachCurrentThread(); 179 JNIEnv* env = AttachCurrentThread();
180 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env); 180 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
181 if (obj.is_null()) 181 if (obj.is_null())
182 return; 182 return;
183 Java_WebContentsDelegateAndroid_rendererResponsive(env, obj); 183 Java_WebContentsDelegateAndroid_rendererResponsive(env, obj);
184 } 184 }
185 185
186 bool WebContentsDelegateAndroid::ShouldCreateWebContents( 186 bool WebContentsDelegateAndroid::ShouldCreateWebContents(
187 WebContents* web_contents, 187 content::WebContents* web_contents,
188 content::SiteInstance* source_site_instance,
188 int32_t route_id, 189 int32_t route_id,
189 int32_t main_frame_route_id, 190 int32_t main_frame_route_id,
190 int32_t main_frame_widget_route_id, 191 int32_t main_frame_widget_route_id,
191 WindowContainerType window_container_type, 192 WindowContainerType window_container_type,
193 const GURL& opener_url,
192 const std::string& frame_name, 194 const std::string& frame_name,
193 const GURL& target_url, 195 const GURL& target_url,
194 const std::string& partition_id, 196 const std::string& partition_id,
195 content::SessionStorageNamespace* session_storage_namespace) { 197 content::SessionStorageNamespace* session_storage_namespace) {
196 JNIEnv* env = AttachCurrentThread(); 198 JNIEnv* env = AttachCurrentThread();
197 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env); 199 ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
198 if (obj.is_null()) 200 if (obj.is_null())
199 return true; 201 return true;
200 ScopedJavaLocalRef<jstring> java_url = 202 ScopedJavaLocalRef<jstring> java_url =
201 ConvertUTF8ToJavaString(env, target_url.spec()); 203 ConvertUTF8ToJavaString(env, target_url.spec());
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 validation_message_bubble_->SetPositionRelativeToAnchor( 413 validation_message_bubble_->SetPositionRelativeToAnchor(
412 rwhv->GetRenderWidgetHost(), anchor_in_root_view); 414 rwhv->GetRenderWidgetHost(), anchor_in_root_view);
413 } 415 }
414 } 416 }
415 417
416 void WebContentsDelegateAndroid::RequestAppBannerFromDevTools( 418 void WebContentsDelegateAndroid::RequestAppBannerFromDevTools(
417 content::WebContents* web_contents) { 419 content::WebContents* web_contents) {
418 } 420 }
419 421
420 } // namespace web_contents_delegate_android 422 } // namespace web_contents_delegate_android
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698