Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_ 5 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_
6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_ 6 #define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUEST_ H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 bool ShouldHandleFindRequestsForEmbedder() const final; 42 bool ShouldHandleFindRequestsForEmbedder() const final;
43 43
44 // content::WebContentsDelegate implementation. 44 // content::WebContentsDelegate implementation.
45 content::WebContents* OpenURLFromTab( 45 content::WebContents* OpenURLFromTab(
46 content::WebContents* source, 46 content::WebContents* source,
47 const content::OpenURLParams& params) final; 47 const content::OpenURLParams& params) final;
48 void CloseContents(content::WebContents* source) final; 48 void CloseContents(content::WebContents* source) final;
49 bool HandleContextMenu(const content::ContextMenuParams& params) final; 49 bool HandleContextMenu(const content::ContextMenuParams& params) final;
50 bool ShouldCreateWebContents( 50 bool ShouldCreateWebContents(
51 content::WebContents* web_contents, 51 content::WebContents* web_contents,
52 content::SiteInstance* source_site_instance,
52 int32_t route_id, 53 int32_t route_id,
53 int32_t main_frame_route_id, 54 int32_t main_frame_route_id,
54 int32_t main_frame_widget_route_id, 55 int32_t main_frame_widget_route_id,
55 WindowContainerType window_container_type, 56 WindowContainerType window_container_type,
57 const GURL& opener_url,
56 const std::string& frame_name, 58 const std::string& frame_name,
57 const GURL& target_url, 59 const GURL& target_url,
58 const std::string& partition_id, 60 const std::string& partition_id,
59 content::SessionStorageNamespace* session_storage_namespace) final; 61 content::SessionStorageNamespace* session_storage_namespace) final;
60 62
61 // content::WebContentsObserver implementation. 63 // content::WebContentsObserver implementation.
62 void DidNavigateMainFrame(const content::LoadCommittedDetails& details, 64 void DidNavigateMainFrame(const content::LoadCommittedDetails& details,
63 const content::FrameNavigateParams& params) final; 65 const content::FrameNavigateParams& params) final;
64 66
65 std::unique_ptr<extensions::ExtensionOptionsGuestDelegate> 67 std::unique_ptr<extensions::ExtensionOptionsGuestDelegate>
66 extension_options_guest_delegate_; 68 extension_options_guest_delegate_;
67 GURL options_page_; 69 GURL options_page_;
68 70
69 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest); 71 DISALLOW_COPY_AND_ASSIGN(ExtensionOptionsGuest);
70 }; 72 };
71 73
72 } // namespace extensions 74 } // namespace extensions
73 75
74 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_ 76 #endif // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSION_OPTIONS_EXTENSION_OPTIONS_GUE ST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698