Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: content/public/browser/web_contents_delegate.cc

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/web_contents_delegate.h" 5 #include "content/public/browser/web_contents_delegate.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 blink::WebDragOperationsMask operations_allowed) { 130 blink::WebDragOperationsMask operations_allowed) {
131 return true; 131 return true;
132 } 132 }
133 133
134 bool WebContentsDelegate::OnGoToEntryOffset(int offset) { 134 bool WebContentsDelegate::OnGoToEntryOffset(int offset) {
135 return true; 135 return true;
136 } 136 }
137 137
138 bool WebContentsDelegate::ShouldCreateWebContents( 138 bool WebContentsDelegate::ShouldCreateWebContents(
139 WebContents* web_contents, 139 WebContents* web_contents,
140 SiteInstance* source_site_instance,
140 int32_t route_id, 141 int32_t route_id,
141 int32_t main_frame_route_id, 142 int32_t main_frame_route_id,
142 int32_t main_frame_widget_route_id, 143 int32_t main_frame_widget_route_id,
143 WindowContainerType window_container_type, 144 WindowContainerType window_container_type,
145 const GURL& opener_url,
144 const std::string& frame_name, 146 const std::string& frame_name,
145 const GURL& target_url, 147 const GURL& target_url,
146 const std::string& partition_id, 148 const std::string& partition_id,
147 SessionStorageNamespace* session_storage_namespace) { 149 SessionStorageNamespace* session_storage_namespace) {
148 return true; 150 return true;
149 } 151 }
150 152
151 JavaScriptDialogManager* WebContentsDelegate::GetJavaScriptDialogManager( 153 JavaScriptDialogManager* WebContentsDelegate::GetJavaScriptDialogManager(
152 WebContents* source) { 154 WebContents* source) {
153 return nullptr; 155 return nullptr;
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 void WebContentsDelegate::ShowCertificateViewerInDevTools( 266 void WebContentsDelegate::ShowCertificateViewerInDevTools(
265 WebContents* web_contents, 267 WebContents* web_contents,
266 scoped_refptr<net::X509Certificate> certificate) { 268 scoped_refptr<net::X509Certificate> certificate) {
267 } 269 }
268 270
269 void WebContentsDelegate::RequestAppBannerFromDevTools( 271 void WebContentsDelegate::RequestAppBannerFromDevTools(
270 content::WebContents* web_contents) { 272 content::WebContents* web_contents) {
271 } 273 }
272 274
273 } // namespace content 275 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698