Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROID_H _ 5 #ifndef COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROID_H _
6 #define COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROID_H _ 6 #define COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROID_H _
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 const content::WebContentsUnresponsiveState& unresponsive_state) override; 74 const content::WebContentsUnresponsiveState& unresponsive_state) override;
75 void RendererResponsive(content::WebContents* source) override; 75 void RendererResponsive(content::WebContents* source) override;
76 void WebContentsCreated(content::WebContents* source_contents, 76 void WebContentsCreated(content::WebContents* source_contents,
77 int opener_render_process_id, 77 int opener_render_process_id,
78 int opener_render_frame_id, 78 int opener_render_frame_id,
79 const std::string& frame_name, 79 const std::string& frame_name,
80 const GURL& target_url, 80 const GURL& target_url,
81 content::WebContents* new_contents) override; 81 content::WebContents* new_contents) override;
82 bool ShouldCreateWebContents( 82 bool ShouldCreateWebContents(
83 content::WebContents* web_contents, 83 content::WebContents* web_contents,
84 content::SiteInstance* source_site_instance,
84 int32_t route_id, 85 int32_t route_id,
85 int32_t main_frame_route_id, 86 int32_t main_frame_route_id,
86 int32_t main_frame_widget_route_id, 87 int32_t main_frame_widget_route_id,
87 WindowContainerType window_container_type, 88 WindowContainerType window_container_type,
89 const GURL& opener_url,
88 const std::string& frame_name, 90 const std::string& frame_name,
89 const GURL& target_url, 91 const GURL& target_url,
90 const std::string& partition_id, 92 const std::string& partition_id,
91 content::SessionStorageNamespace* session_storage_namespace) override; 93 content::SessionStorageNamespace* session_storage_namespace) override;
92 bool OnGoToEntryOffset(int offset) override; 94 bool OnGoToEntryOffset(int offset) override;
93 void CloseContents(content::WebContents* source) override; 95 void CloseContents(content::WebContents* source) override;
94 void MoveContents(content::WebContents* source, 96 void MoveContents(content::WebContents* source,
95 const gfx::Rect& pos) override; 97 const gfx::Rect& pos) override;
96 bool DidAddMessageToConsole(content::WebContents* source, 98 bool DidAddMessageToConsole(content::WebContents* source,
97 int32_t level, 99 int32_t level,
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // strong reference to that object as long as they want to receive callbacks 132 // strong reference to that object as long as they want to receive callbacks
131 // on it. Using a weak ref here allows it to be correctly GCed. 133 // on it. Using a weak ref here allows it to be correctly GCed.
132 JavaObjectWeakGlobalRef weak_java_delegate_; 134 JavaObjectWeakGlobalRef weak_java_delegate_;
133 135
134 std::unique_ptr<ValidationMessageBubbleAndroid> validation_message_bubble_; 136 std::unique_ptr<ValidationMessageBubbleAndroid> validation_message_bubble_;
135 }; 137 };
136 138
137 } // namespace web_contents_delegate_android 139 } // namespace web_contents_delegate_android
138 140
139 #endif // COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROI D_H_ 141 #endif // COMPONENTS_WEB_CONTENTS_DELEGATE_ANDROID_WEB_CONTENTS_DELEGATE_ANDROI D_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698