Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_contents.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 bool* proceed_to_fire_unload) override; 605 bool* proceed_to_fire_unload) override;
606 bool ShouldFocusLocationBarByDefault(content::WebContents* source) override; 606 bool ShouldFocusLocationBarByDefault(content::WebContents* source) override;
607 void ViewSourceForTab(content::WebContents* source, 607 void ViewSourceForTab(content::WebContents* source,
608 const GURL& page_url) override; 608 const GURL& page_url) override;
609 void ViewSourceForFrame(content::WebContents* source, 609 void ViewSourceForFrame(content::WebContents* source,
610 const GURL& frame_url, 610 const GURL& frame_url,
611 const content::PageState& frame_page_state) override; 611 const content::PageState& frame_page_state) override;
612 void ShowRepostFormWarningDialog(content::WebContents* source) override; 612 void ShowRepostFormWarningDialog(content::WebContents* source) override;
613 bool ShouldCreateWebContents( 613 bool ShouldCreateWebContents(
614 content::WebContents* web_contents, 614 content::WebContents* web_contents,
615 content::SiteInstance* source_site_instance,
615 int32_t route_id, 616 int32_t route_id,
616 int32_t main_frame_route_id, 617 int32_t main_frame_route_id,
617 int32_t main_frame_widget_route_id, 618 int32_t main_frame_widget_route_id,
618 WindowContainerType window_container_type, 619 WindowContainerType window_container_type,
620 const GURL& opener_url,
619 const std::string& frame_name, 621 const std::string& frame_name,
620 const GURL& target_url, 622 const GURL& target_url,
621 const std::string& partition_id, 623 const std::string& partition_id,
622 content::SessionStorageNamespace* session_storage_namespace) override; 624 content::SessionStorageNamespace* session_storage_namespace) override;
623 void WebContentsCreated(content::WebContents* source_contents, 625 void WebContentsCreated(content::WebContents* source_contents,
624 int opener_render_process_id, 626 int opener_render_process_id,
625 int opener_render_frame_id, 627 int opener_render_frame_id,
626 const std::string& frame_name, 628 const std::string& frame_name,
627 const GURL& target_url, 629 const GURL& target_url,
628 content::WebContents* new_contents) override; 630 content::WebContents* new_contents) override;
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 852
851 bool ShouldHideUIForFullscreen() const; 853 bool ShouldHideUIForFullscreen() const;
852 854
853 // Returns true if we can start the shutdown sequence for the browser, i.e. 855 // Returns true if we can start the shutdown sequence for the browser, i.e.
854 // the last browser window is being closed. 856 // the last browser window is being closed.
855 bool ShouldStartShutdown() const; 857 bool ShouldStartShutdown() const;
856 858
857 // Creates a BackgroundContents if appropriate; return true if one was 859 // Creates a BackgroundContents if appropriate; return true if one was
858 // created. 860 // created.
859 bool MaybeCreateBackgroundContents( 861 bool MaybeCreateBackgroundContents(
862 content::SiteInstance* source_site_instance,
863 const GURL& opener_url,
860 int32_t route_id, 864 int32_t route_id,
861 int32_t main_frame_route_id, 865 int32_t main_frame_route_id,
862 int32_t main_frame_widget_route_id, 866 int32_t main_frame_widget_route_id,
863 content::WebContents* opener_web_contents,
864 const std::string& frame_name, 867 const std::string& frame_name,
865 const GURL& target_url, 868 const GURL& target_url,
866 const std::string& partition_id, 869 const std::string& partition_id,
867 content::SessionStorageNamespace* session_storage_namespace); 870 content::SessionStorageNamespace* session_storage_namespace);
868 871
869 // Data members ///////////////////////////////////////////////////////////// 872 // Data members /////////////////////////////////////////////////////////////
870 873
871 std::vector<InterstitialObserver*> interstitial_observers_; 874 std::vector<InterstitialObserver*> interstitial_observers_;
872 875
873 content::NotificationRegistrar registrar_; 876 content::NotificationRegistrar registrar_;
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 // The following factory is used for chrome update coalescing. 1014 // The following factory is used for chrome update coalescing.
1012 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1015 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1013 1016
1014 // The following factory is used to close the frame at a later time. 1017 // The following factory is used to close the frame at a later time.
1015 base::WeakPtrFactory<Browser> weak_factory_; 1018 base::WeakPtrFactory<Browser> weak_factory_;
1016 1019
1017 DISALLOW_COPY_AND_ASSIGN(Browser); 1020 DISALLOW_COPY_AND_ASSIGN(Browser);
1018 }; 1021 };
1019 1022
1020 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1023 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_contents.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698