Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: chrome/browser/android/document/document_web_contents_delegate.cc

Issue 2521793003: Fix WebContentsDelegate::ShouldCreateWebContents implementations. (Closed)
Patch Set: Rename in MaybeCreateBackgroundContents Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/document/document_web_contents_delegate.h" 5 #include "chrome/browser/android/document/document_web_contents_delegate.h"
6 6
7 #include "components/web_contents_delegate_android/web_contents_delegate_android .h" 7 #include "components/web_contents_delegate_android/web_contents_delegate_android .h"
8 #include "content/public/browser/web_contents.h" 8 #include "content/public/browser/web_contents.h"
9 #include "jni/DocumentWebContentsDelegate_jni.h" 9 #include "jni/DocumentWebContentsDelegate_jni.h"
10 10
(...skipping 29 matching lines...) Expand all
40 bool* was_blocked) { 40 bool* was_blocked) {
41 NOTREACHED(); 41 NOTREACHED();
42 } 42 }
43 43
44 void DocumentWebContentsDelegate::CloseContents(content::WebContents* source) { 44 void DocumentWebContentsDelegate::CloseContents(content::WebContents* source) {
45 NOTREACHED(); 45 NOTREACHED();
46 } 46 }
47 47
48 bool DocumentWebContentsDelegate::ShouldCreateWebContents( 48 bool DocumentWebContentsDelegate::ShouldCreateWebContents(
49 content::WebContents* web_contents, 49 content::WebContents* web_contents,
50 content::SiteInstance* source_site_instance,
50 int32_t route_id, 51 int32_t route_id,
51 int32_t main_frame_route_id, 52 int32_t main_frame_route_id,
52 int32_t main_frame_widget_route_id, 53 int32_t main_frame_widget_route_id,
53 WindowContainerType window_container_type, 54 WindowContainerType window_container_type,
55 const GURL& opener_url,
54 const std::string& frame_name, 56 const std::string& frame_name,
55 const GURL& target_url, 57 const GURL& target_url,
56 const std::string& partition_id, 58 const std::string& partition_id,
57 content::SessionStorageNamespace* session_storage_namespace) { 59 content::SessionStorageNamespace* session_storage_namespace) {
58 NOTREACHED(); 60 NOTREACHED();
59 return false; 61 return false;
60 } 62 }
61 63
62 static jlong Initialize(JNIEnv* env, const JavaParamRef<jobject>& obj) { 64 static jlong Initialize(JNIEnv* env, const JavaParamRef<jobject>& obj) {
63 return reinterpret_cast<intptr_t>(new DocumentWebContentsDelegate(env, obj)); 65 return reinterpret_cast<intptr_t>(new DocumentWebContentsDelegate(env, obj));
64 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698