[Culprit-finder] Refactor findit testcase and move it to libs.

appengine/findit/lib/gitiles/test/gitiles_repository_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 from datetime import datetime
 import json
 import re
 
 from testing_utils import testing
 
 from lib.gitiles import gitiles_repository
 from lib.gitiles.change_log import ChangeLog
 from libs.http import retry_http_client
+from libs.testcase import TestCase
 
 
 COMMIT_MESSAGE = ('Add popover for snapshot canvas log.\n\n'
                   'Review URL: https://codereview.chromium.org/320423004\n\n'
                   'Review URL: https://codereview.chromium.org/328113005\n\n'
                   'Cr-Commit-Position: refs/heads/master@{#175976}')
 
 COMMIT_LOG = """)]}'
 {
   "commit": "bcfd5a12eea05588aee98b7cf7e032d8cb5b58bb",
@@ skipping 222 matching lines @@
     'committer_time': datetime(2016, 01, 11, 19, 35, 32),
     'commit_url':
         'https://repo.test/+/bcfd',
     'code_review_url': 'https://codereview.chromium.org/328113005',
     'committer_name': 'test1@chromium.org',
     'revision': 'bcfd',
     'reverted_revision': None
 }
 
 
-class HttpClientForGit(retry_http_client.RetryHttpClient):
-
-  def __init__(self):
-    super(HttpClientForGit, self).__init__()
-    self.response_for_url = {}
-
-  def SetResponseForUrl(self, url, response):
-    self.response_for_url[url] = response
-
-  def GetBackoff(self, *_):  # pragma: no cover
-    """Override to avoid sleep."""
-    return 0
-
-  def _Get(self, url, *_):
-    response = self.response_for_url.get(url)
-    if response is None:
-      return 404, 'Not Found'
-    else:
-      return 200, response
-
-  def _Post(self, *_):  # pragma: no cover
-    pass
-
-  def _Put(self, *_):  # pragma: no cover
-    pass
-
-
-class GitRepositoryTest(testing.AppengineTestCase):
+class GitRepositoryTest(TestCase):
 
   def setUp(self):
     super(GitRepositoryTest, self).setUp()
-    self.http_client_for_git = HttpClientForGit()
+    self.http_client_for_git = self.GetMockHttpClient()
     self.repo_url = 'https://repo.test'
-    self.git_repo = gitiles_repository.GitilesRepository(self.repo_url,
-                                                 self.http_client_for_git)
+    self.git_repo = gitiles_repository.GitilesRepository(
+        self.repo_url, self.http_client_for_git)
 
   def testGitRepositoryPropertySetters(self):
-    http_client_for_git = HttpClientForGit()
     git_repo = gitiles_repository.GitilesRepository(
-        http_client=http_client_for_git)
+        http_client=self.http_client_for_git)
     git_repo.repo_url = 'https://repo'
     self.assertEqual(git_repo.repo_url, 'https://repo')
-    self.assertEqual(git_repo.http_client, http_client_for_git)
+    self.assertEqual(git_repo.http_client, self.http_client_for_git)
 
   def testEndingSlashInRepoUrl(self):
     git_repo1 = gitiles_repository.GitilesRepository(
         self.repo_url, self.http_client_for_git)
     self.assertEqual(self.repo_url, git_repo1.repo_url)
 
     git_repo2 = gitiles_repository.GitilesRepository(
         '%s/' % self.repo_url, self.http_client_for_git)
     self.assertEqual(self.repo_url, git_repo2.repo_url)
 
@@ skipping 156 matching lines @@
 
     self.mock(gitiles_repository.GitilesRepository,
         '_SendRequestForJsonResponse', _MockSendRequestForJsonResponse)
 
     changelogs = self.git_repo.GetChangeLogs('0', '2')
 
     self.assertEqual(len(changelogs), 2)
 
   def testGetWrappedGitRepositoryClass(self):
     repo = gitiles_repository.GitilesRepository(
-        'http://repo_url', HttpClientForGit())
+        'http://repo_url', self.http_client_for_git)
 
     self.assertEqual(repo.repo_url, 'http://repo_url')
-    self.assertTrue(isinstance(repo.http_client, HttpClientForGit))