Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2521773003: Revert of [IndexedDB] Delete callbacks state on worker thread exit. (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, jam, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [IndexedDB] Delete callbacks state on worker thread exit. (patchset #1 id:1 of https://codereview.chromium.org/2525443002/ ) Reason for revert: Likely cause of storage/indexeddb/pending-version-change-stuck-works-with-terminate.html crashes: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20218 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/26874 Original issue's description: > [IndexedDB] Delete callbacks state on worker thread exit. > > During refactoring of r430110 the logic to actually delete the internal > state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl > objects that lives on worker threads was accidentally removed. > > BUG=667465 > > Committed: https://crrev.com/ff03e42e8773445a9ee1649dbcbb5b4aae7c2567 > Cr-Commit-Position: refs/heads/master@{#433707} TBR=jsbell@chromium.org,reillyg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667465 Committed: https://crrev.com/9bc73223a90a764ce06cedd247bb09989aad3d08 Cr-Commit-Position: refs/heads/master@{#433725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.h View 2 chunks +4 lines, -12 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
piman
Created Revert of [IndexedDB] Delete callbacks state on worker thread exit.
4 years, 1 month ago (2016-11-22 01:09:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521773003/1
4 years, 1 month ago (2016-11-22 01:10:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 01:12:57 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 01:18:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bc73223a90a764ce06cedd247bb09989aad3d08
Cr-Commit-Position: refs/heads/master@{#433725}

Powered by Google App Engine
This is Rietveld 408576698