Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2521763002: Give ServerWindowCompositorFrameSinkManager ownership of GpuCompositorFrameSink (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give ServerWindowCompositorFrameSinkManager ownership of GpuCompositorFrameSink GpuCompositorFrameSink was outliving WindowServer and GpuServiceProxy but was reaching into those objects at tear down. This was causing segfaults. This CL gives ServerWindowCompositorFrameSinkManager ownership of GpuCompositorFrameSink thereby eliminating the lifetime issue. BUG=666481 Committed: https://crrev.com/1426008b49521475a9b937fd65901abc22e3a349 Cr-Commit-Position: refs/heads/master@{#433679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M services/ui/ws/gpu_compositor_frame_sink.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/gpu_compositor_frame_sink.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Fady Samuel
4 years, 1 month ago (2016-11-21 20:56:39 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-11-21 20:58:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521763002/1
4 years, 1 month ago (2016-11-21 22:36:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 22:50:50 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 22:53:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1426008b49521475a9b937fd65901abc22e3a349
Cr-Commit-Position: refs/heads/master@{#433679}

Powered by Google App Engine
This is Rietveld 408576698