Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2521733002: Revert of Add check_build_deps step to gclient runhooks (Closed)

Created:
4 years, 1 month ago by anthonyvd
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add check_build_deps step to gclient runhooks (patchset #2 id:20001 of https://codereview.chromium.org/2505413003/ ) Reason for revert: This change breaks the following bot: http://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/56654 This appears to be the intended behavior of the change, although the bots should probably not break when it lands to avoid a closed tree. Original issue's description: > Add check_build_deps step to gclient runhooks > > This CL adds a build hook to ensure that any necessary build > dependencies are installed before proceeding with the > build. A failure would indicate install_build_deps.sh > needs to be rerun. > > BUG=666937 > R=dpranke@chromium.org > > Committed: https://crrev.com/e8942c0a68a986313e2927de584a644c8d21b230 > Cr-Commit-Position: refs/heads/master@{#433603} TBR=dpranke@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666937 Committed: https://crrev.com/2ae919e5336c1d4a3a3455f82f85cdd06162d2f1 Cr-Commit-Position: refs/heads/master@{#433611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -34 lines) Patch
M DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D build/check-build-deps.py View 1 chunk +0 lines, -16 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
anthonyvd
Created Revert of Add check_build_deps step to gclient runhooks
4 years, 1 month ago (2016-11-21 19:44:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521733002/1
4 years, 1 month ago (2016-11-21 19:45:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 19:47:51 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:51:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae919e5336c1d4a3a3455f82f85cdd06162d2f1
Cr-Commit-Position: refs/heads/master@{#433611}

Powered by Google App Engine
This is Rietveld 408576698