net: Reset UploadDataStream on HttpNetworkTransaction destruction

net: Reset UploadDataStream on HttpNetworkTransaction destruction

Make UploadDataStream::Reset public.
Call Reset() from HttpNetworkTransaction's dtor.
Add tests.

BUG=244725
TEST=net_unittests --gtest_filter="*HttpNetworkTransactionTest.CancelDuringInitRequestBody*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226433

[hashimoto, 2013-09-30 07:48:41]

Please review.
I'd like to submit this change instead of
https://codereview.chromium.org/23775010/ if it looks good to you.

[mmenke, 2013-10-02 01:02:54]

LGTM, just nits.

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
net/http/http_network_transaction.cc:168: request_->upload_data_stream->Reset();
 // Invalidate pending operations.
Comment isn't accurate - pending operations will still be completed, for the
most part (Since they don't, and can't, check the state of the weak pointer on
other threads).  Maybe "Invalidate pending callbacks."?

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
net/http/http_network_transaction_unittest.cc:7817: TestCompletionCallback
callback1;
nit:  There's no callback2, so "callback" should be fine.

[hashimoto, 2013-10-02 03:45:34]

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
File net/http/http_network_transaction.cc (right):

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
net/http/http_network_transaction.cc:168: request_->upload_data_stream->Reset();
 // Invalidate pending operations.
On 2013/10/02 01:02:54, mmenke wrote:
> Comment isn't accurate - pending operations will still be completed, for the
> most part (Since they don't, and can't, check the state of the weak pointer on
> other threads).  Maybe "Invalidate pending callbacks."?

Done.

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/25217002/diff/3001/net/http/http_network_tran...
net/http/http_network_transaction_unittest.cc:7817: TestCompletionCallback
callback1;
On 2013/10/02 01:02:54, mmenke wrote:
> nit:  There's no callback2, so "callback" should be fine.

Done.

[commit-bot: I haz the power, 2013-10-02 03:46:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/25217002/15001

[commit-bot: I haz the power, 2013-10-02 05:40:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-10-02 07:55:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/25217002/15001

[commit-bot: I haz the power, 2013-10-02 08:14:04]

Change committed as 226433