Update SetThemeColor and SetThemeData

Update SetThemeColor and SetThemeData

The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.

Committed: https://pdfium.googlesource.com/pdfium/+/43170f498b8c619620c4141b2d67ef6ab9a518ca

[dsinclair, 2016-11-21 18:17:47]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-21 18:17:48]

PTAL.

[npm, 2016-11-21 19:19:01]

lgtm

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_chec...
File xfa/fwl/theme/cfwl_checkboxtp.cpp (right):

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_chec...
xfa/fwl/theme/cfwl_checkboxtp.cpp:185: *pData++ = 0, *pData++ = 0, *pData++ =
ArgbEncode(255, 220, 220, 215),
Why are we using commas here?

[Tom Sepez, 2016-11-21 19:38:52]

lgtm

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_arro...
File xfa/fwl/theme/cfwl_arrowdata.cpp (right):

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_arro...
xfa/fwl/theme/cfwl_arrowdata.cpp:40: m_pColorData.reset(new CColorData);
nit: pdfium::MakeUnique<>.  Raw "new"s should be rare.

[dsinclair, 2016-11-21 19:41:25]

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_arro...
File xfa/fwl/theme/cfwl_arrowdata.cpp (right):

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_arro...
xfa/fwl/theme/cfwl_arrowdata.cpp:40: m_pColorData.reset(new CColorData);
On 2016/11/21 19:38:52, Tom Sepez wrote:
> nit: pdfium::MakeUnique<>.  Raw "new"s should be rare.

Done.

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_chec...
File xfa/fwl/theme/cfwl_checkboxtp.cpp (right):

https://codereview.chromium.org/2521683002/diff/20001/xfa/fwl/theme/cfwl_chec...
xfa/fwl/theme/cfwl_checkboxtp.cpp:185: *pData++ = 0, *pData++ = 0, *pData++ =
ArgbEncode(255, 220, 220, 215),
On 2016/11/21 19:19:01, npm wrote:
> Why are we using commas here?

No idea. Fixed.

[dsinclair, 2016-11-21 19:41:28]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-21 19:41:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2521683002/#ps40001
(title: "Review cleanups")

[commit-bot: I haz the power, 2016-11-21 19:41:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:56:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479757288742700,
"parent_rev": "ac9934bfd0570526fb5b688670f32efa56648f5d", "commit_rev":
"43170f498b8c619620c4141b2d67ef6ab9a518ca"}

[commit-bot: I haz the power, 2016-11-21 19:56:10]

Description was changed from

==========
Update SetThemeColor and SetThemeData

The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.
==========

to

==========
Update SetThemeColor and SetThemeData

The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.

Committed:
https://pdfium.googlesource.com/pdfium/+/43170f498b8c619620c4141b2d67ef6ab9a5...
==========

[commit-bot: I haz the power, 2016-11-21 19:56:11]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/43170f498b8c619620c4141b2d67ef6ab9a5...