Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 252163002: Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
michaeln, ericu
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (https://codereview.chromium.org/259773006/) Reason for revert: Causes leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2069 Original issue's description: > Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. > > BUG=108012 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266817 TBR=michaeln@chromium.org,ericu@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -72 lines) Patch
M content/browser/fileapi/blob_storage_context_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 1 chunk +8 lines, -27 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.cc View 1 chunk +27 lines, -39 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
Created Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any ...
6 years, 7 months ago (2014-04-29 10:57:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/252163002/1
6 years, 7 months ago (2014-04-29 10:57:45 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 10:58:22 UTC) #3
Message was sent while issue was closed.
Change committed as 266837

Powered by Google App Engine
This is Rietveld 408576698