third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp - Issue 2521613003: Add flag for tracking descendant paint property updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 2521613003: Add flag for tracking descendant paint property updates (Closed)

Patch Set: Address Xianzhu's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

index 9e8e20aad35b0bbb0f28e5214fe347c2ddb71293..c3d7eef11ca1e6626ed3c0c89ee9a7d33aaaf96d 100644

--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

@@ -26,7 +26,7 @@ class VisualRectMappingTest : public RenderingTest {

const LayoutObject& paintInvalidationContainer) {

Vector<const LayoutObject*> ancestors;

for (const LayoutObject* ancestor = &object; ancestor != layoutView;

- ancestor = ancestor->paintInvalidationParent())

+ ancestor = ancestor->slowPaintInvalidationParentForTesting())

ancestors.append(ancestor);

Vector<Optional<PaintInvalidationState>> paintInvalidationStates(