Add flag for tracking descendant paint property updates

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
@@ skipping 1454 matching lines @@
                       diff.zIndexChanged() || diff.filterChanged() ||
                       diff.backdropFilterChanged())) {
       // We don't need to invalidate paint of objects on SPv2 when only paint
       // property or paint order change. Mark the painting layer needing repaint
       // for changed paint property or paint order. Raster invalidation will be
       // issued if needed during paint.
       ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
 
       // When transform, opacity, etc. change, paint properties will also change
       // so we need to mark this object as needing an update.
-      // TODO(pdr): Also update in the non-spv2 codepath?
       getMutableForPainting().setNeedsPaintPropertyUpdate();
     }
   } else {
     // If transform changed, and the layer does not paint into its own separate
     // backing, then we need to invalidate paints.
     if (diff.transformChanged()) {
       // Text nodes share style with their parents but transforms don't apply to
       // them, hence the !isText() check.
       if (!isText() && (!hasLayer() ||
                         !toLayoutBoxModelObject(this)
@@ skipping 1015 matching lines @@
         if (filterSkipped && walker->hasFilterInducingProperty())
           *filterSkipped = true;
       }
     }
     return multicolContainer;
   }
 
   return o;
 }
 
-LayoutObject* LayoutObject::paintInvalidationParent() const {
+inline LayoutObject* LayoutObject::paintInvalidationParent() const {
   if (isLayoutView())
     return LayoutAPIShim::layoutObjectFrom(frame()->ownerLayoutItem());
   if (isColumnSpanAll())
     return spannerPlaceholder();
   return parent();
 }
 
+LayoutObject* LayoutObject::slowPaintInvalidationParentForTesting() const {
+  return paintInvalidationParent();
+}
+
 bool LayoutObject::isSelectionBorder() const {
   SelectionState st = getSelectionState();
   return st == SelectionStart || st == SelectionEnd || st == SelectionBoth;
 }
 
 inline void LayoutObject::clearLayoutRootIfNeeded() const {
   if (FrameView* view = frameView()) {
     if (!documentBeingDestroyed())
       view->clearLayoutSubtreeRoot(*this);
   }
@@ skipping 188 matching lines @@
 
   if (RuntimeEnabledFeatures::scrollAnchoringEnabled() &&
       m_bitfields.isScrollAnchorObject()) {
     // Clear the bit first so that anchor.clear() doesn't recurse into
     // findReferencingScrollAnchors.
     m_bitfields.setIsScrollAnchorObject(false);
     findReferencingScrollAnchors(this, Clear);
   }
 }
 
+void LayoutObject::setNeedsPaintPropertyUpdate() {
+  m_bitfields.setNeedsPaintPropertyUpdate(true);
+
+  // Mark all ancestors as having a descendant needing paint property updates.
+  // |paintInvalidationParent()| is used to ensure we continue marking across
+  // frame boundaries.
+  LayoutObject* ancestor = paintInvalidationParent();
+  while (ancestor && !ancestor->descendantNeedsPaintPropertyUpdate()) {
+    ancestor->m_bitfields.setDescendantNeedsPaintPropertyUpdate(true);
+    ancestor = ancestor->paintInvalidationParent();
+  }
+}
+
+void LayoutObject::setAncestorsNeedPaintPropertyUpdateForMainThreadScrolling() {
+  LayoutObject* ancestor = paintInvalidationParent();
+  while (ancestor) {
+    ancestor->setNeedsPaintPropertyUpdate();
+    ancestor = ancestor->paintInvalidationParent();
+  }
+}
+
 void LayoutObject::maybeClearIsScrollAnchorObject() {
   if (!m_bitfields.isScrollAnchorObject())
     return;
   m_bitfields.setIsScrollAnchorObject(
       findReferencingScrollAnchors(this, DontClear));
 }
 
 void LayoutObject::removeFromLayoutFlowThread() {
   if (!isInsideFlowThread())
     return;
@@ skipping 736 matching lines @@
     const blink::LayoutObject* root = object1;
     while (root->parent())
       root = root->parent();
     root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
   } else {
     WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
   }
 }
 
 #endif