Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2521613003: Add flag for tracking descendant paint property updates (Closed)
Patch Set: Address Xianzhu's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1476 1476
1477 m_backgroundAttachmentFixedObjects.add(object); 1477 m_backgroundAttachmentFixedObjects.add(object);
1478 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator()) 1478 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
1479 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidChange( 1479 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidChange(
1480 this); 1480 this);
1481 1481
1482 // Ensure main thread scrolling reasons are recomputed. 1482 // Ensure main thread scrolling reasons are recomputed.
1483 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 1483 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
1484 setNeedsPaintPropertyUpdate(); 1484 setNeedsPaintPropertyUpdate();
1485 // The object's scroll properties are not affected by its own background. 1485 // The object's scroll properties are not affected by its own background.
1486 object->setAllAncestorsNeedPaintPropertyUpdate(); 1486 object->setAncestorsNeedPaintPropertyUpdateForMainThreadScrolling();
1487 } 1487 }
1488 } 1488 }
1489 1489
1490 void FrameView::removeBackgroundAttachmentFixedObject(LayoutObject* object) { 1490 void FrameView::removeBackgroundAttachmentFixedObject(LayoutObject* object) {
1491 ASSERT(m_backgroundAttachmentFixedObjects.contains(object)); 1491 ASSERT(m_backgroundAttachmentFixedObjects.contains(object));
1492 1492
1493 m_backgroundAttachmentFixedObjects.remove(object); 1493 m_backgroundAttachmentFixedObjects.remove(object);
1494 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator()) 1494 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
1495 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidChange( 1495 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidChange(
1496 this); 1496 this);
1497 1497
1498 // Ensure main thread scrolling reasons are recomputed. 1498 // Ensure main thread scrolling reasons are recomputed.
1499 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 1499 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
1500 setNeedsPaintPropertyUpdate(); 1500 setNeedsPaintPropertyUpdate();
1501 // The object's scroll properties are not affected by its own background. 1501 // The object's scroll properties are not affected by its own background.
1502 object->setAllAncestorsNeedPaintPropertyUpdate(); 1502 object->setAncestorsNeedPaintPropertyUpdateForMainThreadScrolling();
1503 } 1503 }
1504 } 1504 }
1505 1505
1506 void FrameView::addViewportConstrainedObject(LayoutObject* object) { 1506 void FrameView::addViewportConstrainedObject(LayoutObject* object) {
1507 if (!m_viewportConstrainedObjects) 1507 if (!m_viewportConstrainedObjects)
1508 m_viewportConstrainedObjects = wrapUnique(new ViewportConstrainedObjectSet); 1508 m_viewportConstrainedObjects = wrapUnique(new ViewportConstrainedObjectSet);
1509 1509
1510 if (!m_viewportConstrainedObjects->contains(object)) { 1510 if (!m_viewportConstrainedObjects->contains(object)) {
1511 m_viewportConstrainedObjects->add(object); 1511 m_viewportConstrainedObjects->add(object);
1512 1512
(...skipping 3131 matching lines...) Expand 10 before | Expand all | Expand 10 after
4644 DCHECK(m_frame->isMainFrame()); 4644 DCHECK(m_frame->isMainFrame());
4645 return m_initialViewportSize.width(); 4645 return m_initialViewportSize.width();
4646 } 4646 }
4647 4647
4648 int FrameView::initialViewportHeight() const { 4648 int FrameView::initialViewportHeight() const {
4649 DCHECK(m_frame->isMainFrame()); 4649 DCHECK(m_frame->isMainFrame());
4650 return m_initialViewportSize.height(); 4650 return m_initialViewportSize.height();
4651 } 4651 }
4652 4652
4653 } // namespace blink 4653 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698