Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2521603002: VM: [Kernel] Cherry-pick from dart-lang/kernel_sdk (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: [Kernel] Cherry-pick from dart-lang/kernel_sdk Do not eagerly finalize types in procedures. Translate types in procedures without finalizing them. This change supercedes https://chromereviews.googleplex.com/516397015/. Review URL: https://chromereviews.googleplex.com/521117013 . R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/27aeb31a8daf675befcd3c04b76a3e993ce5ebd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M runtime/vm/kernel_reader.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
4 years, 1 month ago (2016-11-21 15:02:58 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-21 15:20:33 UTC) #3
kustermann
4 years, 1 month ago (2016-11-21 15:44:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27aeb31a8daf675befcd3c04b76a3e993ce5ebd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698