Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2521583003: Adds speculative CHECKs to diagnose AudioManager crashes. (Closed)

Created:
4 years, 1 month ago by alokp
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds speculative CHECKs to diagnose AudioManager crashes. Adds CHECKs to verify that input/output streams are created/released on the audio thread. BUG=608049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e222406a7ee930c64e5401a3e5099acc137c743e Cr-Commit-Position: refs/heads/master@{#433762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M media/audio/audio_manager_base.cc View 5 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alokp
4 years, 1 month ago (2016-11-21 23:43:11 UTC) #3
DaleCurtis
lgtm
4 years, 1 month ago (2016-11-22 00:12:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521583003/1
4 years, 1 month ago (2016-11-22 00:20:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 03:05:36 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 03:07:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e222406a7ee930c64e5401a3e5099acc137c743e
Cr-Commit-Position: refs/heads/master@{#433762}

Powered by Google App Engine
This is Rietveld 408576698