net/quic/chromium/quic_chromium_client_session.cc - Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_chromium_client_session.cc

diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc

index c578c90d013dac3690d0c5dbb8f2528c5e49e222..3bf85988bb9e96287fbbbfb067d445c248a850a4 100644

--- a/net/quic/chromium/quic_chromium_client_session.cc

+++ b/net/quic/chromium/quic_chromium_client_session.cc

@@ -243,6 +243,7 @@ QuicChromiumClientSession::QuicChromiumClientSession(

base::TimeTicks dns_resolution_start_time,

base::TimeTicks dns_resolution_end_time,

QuicClientPushPromiseIndex* push_promise_index,

+ ServerPushDelegate* push_delegate,

base::TaskRunner* task_runner,

std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,

NetLog* net_log)

@@ -263,7 +264,7 @@ QuicChromiumClientSession::QuicChromiumClientSession(

going_away_(false),

port_migration_detected_(false),

token_binding_signatures_(kTokenBindingSignatureMapSize),

- push_delegate_(nullptr),

+ push_delegate_(push_delegate),

streams_pushed_count_(0),

streams_pushed_and_claimed_count_(0),

bytes_pushed_count_(0),