Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_session.cc

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/quic/chromium/quic_chromium_client_session.h ('K') | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index dd9785986f3c4bb6cd58e760c96273ecf6c0397c..175a8b764b4cb948282b7e128ef62795d18c53de 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -651,6 +651,7 @@ SpdySession::SpdySession(const SpdySessionKey& spdy_session_key,
size_t session_max_recv_window_size,
size_t stream_max_recv_window_size,
TimeFunc time_func,
+ ServerPushDelegate* push_delegate,
ProxyDelegate* proxy_delegate,
NetLog* net_log)
: in_io_loop_(false),
@@ -662,7 +663,7 @@ SpdySession::SpdySession(const SpdySessionKey& spdy_session_key,
stream_hi_water_mark_(kFirstStreamId),
last_accepted_push_stream_id_(0),
unclaimed_pushed_streams_(this),
- push_delegate_(nullptr),
+ push_delegate_(push_delegate),
Ryan Hamilton 2016/11/23 20:43:30 ditto on the non-null check question.
Zhongyi Shi 2016/11/23 23:53:49 Acknowledged.
num_pushed_streams_(0u),
num_active_pushed_streams_(0u),
bytes_pushed_count_(0u),
« net/quic/chromium/quic_chromium_client_session.h ('K') | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_session_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698