Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/quic/chromium/quic_stream_factory.cc

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_stream_factory.cc
diff --git a/net/quic/chromium/quic_stream_factory.cc b/net/quic/chromium/quic_stream_factory.cc
index d7cc346de9363a753f88a469d51a8e862770d6e4..89242430d4e153de381aa342b0388b8944494a09 100644
--- a/net/quic/chromium/quic_stream_factory.cc
+++ b/net/quic/chromium/quic_stream_factory.cc
@@ -748,6 +748,7 @@ QuicStreamFactory::QuicStreamFactory(
host_resolver_(host_resolver),
client_socket_factory_(client_socket_factory),
http_server_properties_(http_server_properties),
+ push_delegate_(nullptr),
proxy_delegate_(proxy_delegate),
transport_security_state_(transport_security_state),
cert_transparency_verifier_(cert_transparency_verifier),
@@ -1708,7 +1709,8 @@ int QuicStreamFactory::CreateSession(
server_id, yield_after_packets_, yield_after_duration_, cert_verify_flags,
config, &crypto_config_, network_connection_.GetDescription(),
dns_resolution_start_time, dns_resolution_end_time, &push_promise_index_,
- task_runner_, std::move(socket_performance_watcher), net_log.net_log());
+ push_delegate_, task_runner_, std::move(socket_performance_watcher),
+ net_log.net_log());
all_sessions_[*session] = key; // owning pointer
writer->set_delegate(*session);

Powered by Google App Engine
This is Rietveld 408576698