Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: net/quic/chromium/quic_chromium_client_session_test.cc

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session_test.cc
diff --git a/net/quic/chromium/quic_chromium_client_session_test.cc b/net/quic/chromium/quic_chromium_client_session_test.cc
index 0e73a009980e75c9c97ce41f88028bf2545f2fb9..e51700db1b303fe856a3a6f6a191b46496f6e04a 100644
--- a/net/quic/chromium/quic_chromium_client_session_test.cc
+++ b/net/quic/chromium/quic_chromium_client_session_test.cc
@@ -125,7 +125,8 @@ class QuicChromiumClientSessionTest
QuicTime::Delta::FromMilliseconds(kQuicYieldAfterDurationMilliseconds),
/*cert_verify_flags=*/0, DefaultQuicConfig(), &crypto_config_,
"CONNECTION_UNKNOWN", base::TimeTicks::Now(), base::TimeTicks::Now(),
- &push_promise_index_, base::ThreadTaskRunnerHandle::Get().get(),
+ &push_promise_index_, &test_push_delegate_,
+ base::ThreadTaskRunnerHandle::Get().get(),
/*socket_performance_watcher=*/nullptr, &net_log_));
scoped_refptr<X509Certificate> cert(
@@ -325,7 +326,6 @@ TEST_P(QuicChromiumClientSessionTest, CancelPushWhenPendingValidation) {
socket_data_.reset(new SequencedSocketData(reads, arraysize(reads), writes,
arraysize(writes)));
Initialize();
- session_->set_push_delegate(&test_push_delegate_);
ProofVerifyDetailsChromium details;
details.cert_verify_result.verified_cert =
@@ -377,7 +377,6 @@ TEST_P(QuicChromiumClientSessionTest, CancelPushBeforeReceivingResponse) {
socket_data_.reset(new SequencedSocketData(reads, arraysize(reads), writes,
arraysize(writes)));
Initialize();
- session_->set_push_delegate(&test_push_delegate_);
ProofVerifyDetailsChromium details;
details.cert_verify_result.verified_cert =
@@ -425,7 +424,6 @@ TEST_P(QuicChromiumClientSessionTest, CancelPushAfterReceivingResponse) {
socket_data_.reset(new SequencedSocketData(reads, arraysize(reads), writes,
arraysize(writes)));
Initialize();
- session_->set_push_delegate(&test_push_delegate_);
ProofVerifyDetailsChromium details;
details.cert_verify_result.verified_cert =

Powered by Google App Engine
This is Rietveld 408576698