Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/http/http_network_session.h

Issue 2521573006: Server push cancellation: change the ownership of ServerPushDelegate to HttpNetworkSession. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index f45ea432d5f02a251f33f045a6cd5ff5fdcc6174..09627fcd341c809135f39c43614e116b155e9363 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -270,6 +270,10 @@ class NET_EXPORT HttpNetworkSession
bool IsProtocolEnabled(NextProto protocol) const;
+ // Takes ownership of |push_delegate| and pass the references to
+ // |quic_stream_factory_| and |spdy_session_pool_|.
Ryan Hamilton 2016/11/23 04:22:41 No reason to mention ownership, since the argument
Zhongyi Shi 2016/11/23 06:20:02 Done.
+ void SetServerPushDelegate(std::unique_ptr<ServerPushDelegate> push_delegate);
+
// Populates |*alpn_protos| with protocols to be used with ALPN.
void GetAlpnProtos(NextProtoVector* alpn_protos) const;
@@ -304,6 +308,7 @@ class NET_EXPORT HttpNetworkSession
SSLClientAuthCache ssl_client_auth_cache_;
std::unique_ptr<ClientSocketPoolManager> normal_socket_pool_manager_;
std::unique_ptr<ClientSocketPoolManager> websocket_socket_pool_manager_;
+ std::unique_ptr<ServerPushDelegate> push_delegate_;
QuicStreamFactory quic_stream_factory_;
SpdySessionPool spdy_session_pool_;
std::unique_ptr<HttpStreamFactory> http_stream_factory_;
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698