Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2521543004: Avoid calling a virtual method on a null document in lifecycle(). (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid calling a virtual method on a null document in lifecycle(). The bug was found by UBSan Vptr bot. BUG=667521 Committed: https://crrev.com/ed07d372b9ec31e3b47074e5b95941c52c9c9fca Cr-Commit-Position: refs/heads/master@{#433688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
krasin1
4 years, 1 month ago (2016-11-21 22:53:35 UTC) #5
bokan
Is there a bug we can put in the BUG= line? lgtm otherwise.
4 years, 1 month ago (2016-11-21 22:56:22 UTC) #6
krasin1
On 2016/11/21 22:56:22, bokan wrote: > Is there a bug we can put in the ...
4 years, 1 month ago (2016-11-21 23:14:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521543004/1
4 years, 1 month ago (2016-11-21 23:15:30 UTC) #10
krasin1
And thank you for the instant response!
4 years, 1 month ago (2016-11-21 23:15:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 23:23:57 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:26:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed07d372b9ec31e3b47074e5b95941c52c9c9fca
Cr-Commit-Position: refs/heads/master@{#433688}

Powered by Google App Engine
This is Rietveld 408576698