Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2521543003: Add stream operator for SurfaceId/FrameSinkId/LocalFrameId. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
msw, sadrul, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, devtools-reviews_chromium.org, fsamuel, kalyank, pfeldman, rjkroege, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add stream operator for SurfaceId/FrameSinkId/LocalFrameId. Allow use with with DCHECK_EQ/DCHECK_NE and other testing/logging macros. Also fix some includes. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/8652b0d306c0996a732fb952af4cfb9f735741ef Cr-Commit-Position: refs/heads/master@{#434056}

Patch Set 1 #

Patch Set 2 : Add another missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -20 lines) Patch
M ash/common/devtools/ash_devtools_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/frame_sink_id.h View 2 chunks +7 lines, -5 lines 0 comments Download
A cc/surfaces/frame_sink_id.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M cc/surfaces/local_frame_id.h View 2 chunks +6 lines, -5 lines 0 comments Download
A cc/surfaces/local_frame_id.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M cc/surfaces/surface_id.h View 3 chunks +4 lines, -8 lines 0 comments Download
A cc/surfaces/surface_id.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
kylechar
+enne for cc/* +sadrul for ash/common/devtools +msw services/ui/ws/*
4 years, 1 month ago (2016-11-22 15:36:49 UTC) #3
enne (OOO)
lgtm
4 years, 1 month ago (2016-11-22 18:20:37 UTC) #5
msw
lgtm
4 years, 1 month ago (2016-11-22 18:51:40 UTC) #6
sadrul
lgtm
4 years, 1 month ago (2016-11-22 19:00:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521543003/1
4 years, 1 month ago (2016-11-22 19:03:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/168700)
4 years, 1 month ago (2016-11-22 19:27:48 UTC) #11
kylechar
Thanks for the quick reviews!
4 years, 1 month ago (2016-11-23 00:17:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521543003/20001
4 years, 1 month ago (2016-11-23 00:18:28 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 01:07:45 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 01:11:09 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8652b0d306c0996a732fb952af4cfb9f735741ef
Cr-Commit-Position: refs/heads/master@{#434056}

Powered by Google App Engine
This is Rietveld 408576698