Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 252153002: Fix chrome.usb control transfer. (Closed)

Created:
6 years, 7 months ago by kha
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix chrome.usb control transfer. Incorrect data size check prevented API from returning data received from USB device and it returned uninitialized data instead. BUG=368176 TEST=manually tested with USBASP as target device Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/usb_service/usb_device_handle.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
kha
6 years, 7 months ago (2014-04-29 10:00:47 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-04-29 10:06:37 UTC) #2
Ken Rockot(use gerrit already)
Thanks, this is a nice catch. LGTM.
6 years, 7 months ago (2014-04-29 15:32:49 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-04-29 15:32:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
6 years, 7 months ago (2014-04-29 15:33:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 16:29:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium
6 years, 7 months ago (2014-04-29 16:29:43 UTC) #7
kha
On 2014/04/29 16:29:43, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-29 18:58:38 UTC) #8
Ken Rockot(use gerrit already)
On 2014/04/29 18:58:38, kha wrote: > On 2014/04/29 16:29:43, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-04-29 19:17:41 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-04-29 19:17:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
6 years, 7 months ago (2014-04-29 19:19:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:44:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:44:20 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-04-29 21:45:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
6 years, 7 months ago (2014-04-29 21:47:56 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 23:20:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 23:20:26 UTC) #17
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-04-29 23:26:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
6 years, 7 months ago (2014-04-29 23:27:58 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:21:19 UTC) #20
Message was sent while issue was closed.
Change committed as 267116

Powered by Google App Engine
This is Rietveld 408576698