|
|
Created:
6 years, 7 months ago by kha Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix chrome.usb control transfer.
Incorrect data size check prevented API from returning data received
from USB device and it returned uninitialized data instead.
BUG=368176
TEST=manually tested with USBASP as target device
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267116
Patch Set 1 #
Messages
Total messages: 20 (0 generated)
lgtm
Thanks, this is a nice catch. LGTM.
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium
On 2014/04/29 16:29:43, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_chromium_compile_dbg on tryserver.chromium Seems builder is broken, found this from logs svn: Can't open file 'LayoutTests\fast\media\.svn\entries': The file or directory is corrupted and unreadable
On 2014/04/29 18:58:38, kha wrote: > On 2014/04/29 16:29:43, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > win_chromium_compile_dbg on tryserver.chromium > > Seems builder is broken, found this from logs > > svn: Can't open file 'LayoutTests\fast\media\.svn\entries': The file or > directory is corrupted and unreadable Yep. It'll get through eventually
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khautio@gmail.com/252153002/1
Message was sent while issue was closed.
Change committed as 267116 |