Change SVG layout tree output to be more meaningful and consistent

Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org

Committed: https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2
Cr-Commit-Position: refs/heads/master@{#433709}

[Xianzhu, 2016-11-21 04:26:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 04:26:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 06:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 06:54:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-11-21 16:51:41]

Description was changed from

==========
Change SVG layout tree output to be more meaningful

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output was incorrect when the first
  run is not at the top-left corner (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to 2 fraction digits and 2) we already output float positions
  for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
==========

to

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output was incorrect when the first
  run is not at the top-left corner (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to 2 fraction digits and 2) we already output float positions
  for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
==========

[Xianzhu, 2016-11-21 16:52:48]

Description was changed from

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output was incorrect when the first
  run is not at the top-left corner (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to 2 fraction digits and 2) we already output float positions
  for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
==========

to

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
==========

[Xianzhu, 2016-11-21 16:53:04]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-11-21 19:19:41]

LGTM

+cc fs@opera.com just as an FYI.

[Xianzhu, 2016-11-21 20:28:31]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-21 20:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2521473002/#ps20001
(title: "Rebaseline-cl")

[commit-bot: I haz the power, 2016-11-21 20:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:41:25]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xianzhu, 2016-11-22 00:12:23]

Description was changed from

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
==========

to

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org
==========

[Xianzhu, 2016-11-22 00:12:31]

Committed patchset #2 (id:20001) to pending queue manually as
a0ecf6121e983f6ab2ead6fa49df4d7542056e18 (presubmit successful).

[commit-bot: I haz the power, 2016-11-22 00:27:16]

Description was changed from

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org
==========

to

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org

Committed: https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2
Cr-Commit-Position: refs/heads/master@{#433709}
==========

[commit-bot: I haz the power, 2016-11-22 00:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2
Cr-Commit-Position: refs/heads/master@{#433709}

[Xianzhu, 2016-11-22 00:41:29]

Description was changed from

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org

Committed: https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2
Cr-Commit-Position: refs/heads/master@{#433709}
==========

to

==========
Change SVG layout tree output to be more meaningful and consistent

- Change position output of SVGRoot from absoluteVisualRect() to
  frameRect() to keep consistency to non-SVG objects, and avoid
  confusion when the output's location overlaps with parent's location.

- Change position output of other SVG objects from absoluteVisualRect()
  to objectBoundingBox() to make it similar to other outputs which use
  local geometries.

- Change position output of SVG inline text from
  FloatRect(firstRunOrigin(), boundingBox().width()) to
  objectBoundingBox(). The original output didn't make sense when the
  first run is not at the top-left corner
  (e.g. <text dy="0,-5">ABC</text>).

- Remove enclosingIntRect() to let the output reflect subpixel layouts.
  The possibility of more flakiness is low because 1) the numbers are
  rounded to keep 2 fraction digits and 2) we already output float
  positions for svg line layout geometries.

This is a preparation before unifying SVGLayoutText coordinate spaces
(to let the underlying LayoutBlockFlow see consistent coordinates for
texts and outlines).

BUG=666416
R=pdr@chromium.org

Committed: https://crrev.com/56fe6c7ab880c20c1a6c97532d70018b5c3b47d2
Cr-Commit-Position: refs/heads/master@{#433709}
==========

[Xianzhu, 2016-11-22 00:41:50]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-22 00:41:57]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2521473002/#ps30001
(title: "-")

[commit-bot: I haz the power, 2016-11-22 00:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-22 01:08:40]

The CQ bit was unchecked by wangxianzhu@chromium.org