third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 2521463002: Changed EBoxDirection to an enum class and renamed its members to keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 2521463002: Changed EBoxDirection to an enum class and renamed its members to keywords (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index 00be42e62b562a3327660e22f3a59bd251774874..3744b97dde4427f8e98f2333b094efe0e5df180f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -43,9 +43,9 @@ class FlexBoxIterator {

: m_box(parent), m_largestOrdinal(1) {

if (m_box->style()->boxOrient() == HORIZONTAL &&

!m_box->style()->isLeftToRightDirection())

- m_forward = m_box->style()->boxDirection() != BNORMAL;

+ m_forward = m_box->style()->boxDirection() != EBoxDirection::Normal;

else

- m_forward = m_box->style()->boxDirection() == BNORMAL;

+ m_forward = m_box->style()->boxDirection() == EBoxDirection::Normal;

if (!m_forward) {

// No choice, since we're going backwards, we have to find out the highest

// ordinal up front.