Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2521433002: Regen the analysis server spec to include the diagnostic domain. (Closed)

Created:
4 years, 1 month ago by devoncarew
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Regen the analysis server spec to include the diagnostic domain. BUG= R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/c4bcfb5a0253604949e96af2f93c20659e1662da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 6 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
devoncarew
Regen the analysis server spec to include the diagnostic domain. It hadn't been included in ...
4 years, 1 month ago (2016-11-20 08:10:17 UTC) #2
pquitslund
lgtm
4 years, 1 month ago (2016-11-20 15:35:28 UTC) #3
scheglov
I thought it was a deliberate decision to exclude this domain from DAS public API. ...
4 years, 1 month ago (2016-11-20 17:13:53 UTC) #4
devoncarew
It had had an experimental tag for a while, but that was dropped perhaps Q1 ...
4 years, 1 month ago (2016-11-20 18:25:24 UTC) #5
devoncarew
Committed patchset #1 (id:1) manually as c4bcfb5a0253604949e96af2f93c20659e1662da (presubmit successful).
4 years, 1 month ago (2016-11-20 18:27:58 UTC) #7
Brian Wilkerson
4 years, 1 month ago (2016-11-21 14:55:08 UTC) #8
Message was sent while issue was closed.
lgtm

It was a deliberate decision; we wanted to wait until we knew whether the
information is useful to users. I still haven't seen any evidence that that's
the case, so I'll just have to take other people's word for it that we actually
want this API.

Powered by Google App Engine
This is Rietveld 408576698