Issue 252143003: Revert of Makes change_id unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252143003: Revert of Makes change_id unsigned (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 7 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Makes change_id unsigned (https://codereview.chromium.org/253883005/) Reason for revert: Breaks compile on win builder: http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/29440 Original issue's description: > Makes change_id unsigned > > Easier this way for clients to track and not worry about overflow. > > BUG=none > TEST=none > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266793 TBR=ben@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266799

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -51 lines)			Patch
M	mojo/examples/sample_view_manager_app/sample_view_manager_app.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/services/public/interfaces/view_manager/view_manager.mojom	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	mojo/services/view_manager/ids.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/services/view_manager/root_node_manager.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/services/view_manager/root_node_manager.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.h	View	3 chunks	+10 lines, -11 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.cc	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection_unittest.cc	View	7 chunks	+8 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/252143003/1

6 years, 7 months ago (2014-04-29 09:21:16 UTC) #2

Message was sent while issue was closed.

Change committed as 266799

Expand Messages | Collapse Messages