Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: runtime/observatory/tests/service/rewind_optimized_out_test.dart

Issue 2521413002: Revert "Implement rewind: drop one or more frames from the debugger." (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/rewind_optimized_out_test.dart
diff --git a/runtime/observatory/tests/service/rewind_optimized_out_test.dart b/runtime/observatory/tests/service/rewind_optimized_out_test.dart
deleted file mode 100644
index 23b8c9a9a67015471d12df23ba8759f2b0c4ff8b..0000000000000000000000000000000000000000
--- a/runtime/observatory/tests/service/rewind_optimized_out_test.dart
+++ /dev/null
@@ -1,86 +0,0 @@
-// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-// VMOptions=--error_on_bad_type --error_on_bad_override
-
-import 'dart:developer';
-import 'package:observatory/service_io.dart';
-import 'package:unittest/unittest.dart';
-import 'service_test_common.dart';
-import 'test_helper.dart';
-
-const alwaysInline = "AlwaysInline";
-const noInline = "NeverInline";
-
-int LINE_A = 35;
-int LINE_B = 40;
-int LINE_C = 43;
-int LINE_D = 47;
-
-int global = 0;
-
-@noInline
-b3(x) {
- int sum = 0;
- try {
- for (int i = 0; i < x; i++) {
- sum += x;
- }
- } catch (e) {
- print("caught $e");
- }
- if (global >= 100) {
- debugger();
- }
- global = global + 1; // Line A
- return sum;
-}
-
-@alwaysInline
-b2(x) => b3(x); // Line B
-
-@alwaysInline
-b1(x) => b2(x); // Line C
-
-test() {
- while (true) {
- b1(10000); // Line D
- }
-}
-
-var tests = [
- hasStoppedAtBreakpoint,
- stoppedAtLine(LINE_A),
-
- (Isolate isolate) async {
- // We are at our breakpoint with global=100.
- var result = await isolate.rootLibrary.evaluate('global');
- print('global is $result');
- expect(result.type, equals('Instance'));
- expect(result.valueAsString, equals('100'));
-
- // Rewind the top stack frame.
- bool caughtException;
- try {
- result = await isolate.rewind(1);
- expect(false, isTrue, reason:'Unreachable');
- } on ServerRpcException catch(e) {
- caughtException = true;
- expect(e.code, equals(ServerRpcException.kCannotResume));
- expect(e.message,
- 'Cannot rewind to frame 1 due to conflicting compiler '
- 'optimizations. Run the vm with --no-prune-dead-locals to '
- 'disallow these optimizations. Next valid rewind frame is 4.');
- }
- expect(caughtException, isTrue);
- },
-];
-
-
-main(args) => runIsolateTests(args, tests, testeeConcurrent: test,
- extraArgs:
- ['--trace-rewind',
- '--prune-dead-locals',
- '--enable-inlining-annotations',
- '--no-background-compilation',
- '--optimization-counter-threshold=10']);

Powered by Google App Engine
This is Rietveld 408576698