Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2521363003: Implement SearchEngine for the new driver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement SearchEngine for the new driver. Only search for references, and only to local variables is implemented so far. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/26307d77b607834aeb921f53ea4bfe0deba8c74c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 7 chunks +18 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +3 lines, -10 lines 0 comments Download
A pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 1 chunk +149 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/search.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-22 19:23:43 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-22 19:29:02 UTC) #2
scheglov
4 years, 1 month ago (2016-11-22 20:01:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26307d77b607834aeb921f53ea4bfe0deba8c74c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698