chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java - Issue 2521353005: [OfflinePages] Call NotifyInterrupted for pending requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

Issue 2521353005: [OfflinePages] Call NotifyInterrupted for pending requests (Closed)

Patch Set: Fix indeterminate progress bar for Downloading... Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/offline_pages/downloads/download_notifying_observer.h » ('j') | components/offline_pages/downloads/download_notifying_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

index ea908f8d1827e625c6374597c1d099b43e39f125..21fb902008ca34fa5c984effe30e372e1efd3996 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java

@@ -77,8 +77,9 @@ public class OfflinePageNotificationBridge {

DownloadNotifier notifier = getDownloadNotifier(context);

if (notifier == null) return;

+ // Use -1 percentage for interdeterminate progress bar (until we have better value).

// TODO(qinmin): get the download percentage from native code,

- int percentage = isOfflining ? 0 : -1;

+ int percentage = -1;

DownloadInfo downloadInfo = new DownloadInfo.Builder()

.setIsOfflinePage(true)

.setDownloadGuid(guid)