Remove build_dir arg from xvfb.py

Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470
Committed: https://crrev.com/3d074282edea55cc2406dbe8b62f70f6bf98b78d
Cr-Commit-Position: refs/heads/master@{#436652}

[Tom (Use chromium acct), 2016-11-23 02:14:07]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 03:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 03:26:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom (Use chromium acct), 2016-11-29 03:13:29]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 03:13:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 05:03:17]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-30 17:43:28]

Description was changed from

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
==========

to

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
==========

[Tom (Use chromium acct), 2016-12-01 22:23:24]

Description was changed from

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
==========

to

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470
==========

[Tom (Use chromium acct), 2016-12-05 23:52:24]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 23:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 00:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 00:45:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2016-12-06 02:17:55]

Mostly lgtm, but have you checked to ensure that there are no scripts in the
build repo that are invoking xvfb.py directly?

[Tom (Use chromium acct), 2016-12-06 18:15:15]

On 2016/12/06 02:17:55, Dirk Pranke wrote:
> Mostly lgtm, but have you checked to ensure that there are no scripts in the
> build repo that are invoking xvfb.py directly?

The only reference I'm seeing is in scripts/slave/isolation/recipes.isolate
https://cs.chromium.org/chromium/build/scripts/slave/isolation/recipes.isolat...

But I think that's in reference to the xvfb.py script in //build (which is no
longer in use and can be removed??)

[Tom (Use chromium acct), 2016-12-06 18:15:19]

On 2016/12/06 02:17:55, Dirk Pranke wrote:
> Mostly lgtm, but have you checked to ensure that there are no scripts in the
> build repo that are invoking xvfb.py directly?

The only reference I'm seeing is in scripts/slave/isolation/recipes.isolate
https://cs.chromium.org/chromium/build/scripts/slave/isolation/recipes.isolat...

But I think that's in reference to the xvfb.py script in //build (which is no
longer in use and can be removed??)

[Tom (Use chromium acct), 2016-12-06 18:15:34]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-12-06 18:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 18:21:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481048134053040,
"parent_rev": "222b7509ef651e2c303dd70393a79123c7c61bd9", "commit_rev":
"2498faecfab1dc1c147d17c85047336a2bf1aba3"}

[commit-bot: I haz the power, 2016-12-06 18:21:44]

Description was changed from

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470
==========

to

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470
==========

[commit-bot: I haz the power, 2016-12-06 18:21:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 18:23:22]

Description was changed from

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470
==========

to

==========
Remove build_dir arg from xvfb.py

R=dpranke@chromium.org
BUG=670470

Committed: https://crrev.com/3d074282edea55cc2406dbe8b62f70f6bf98b78d
Cr-Commit-Position: refs/heads/master@{#436652}
==========

[commit-bot: I haz the power, 2016-12-06 18:23:23]

Patchset 3 (id:??) landed as
https://crrev.com/3d074282edea55cc2406dbe8b62f70f6bf98b78d
Cr-Commit-Position: refs/heads/master@{#436652}

[Dirk Pranke, 2016-12-06 20:11:30]

On 2016/12/06 18:15:19, Tom Anderson wrote:
> On 2016/12/06 02:17:55, Dirk Pranke wrote:
> > Mostly lgtm, but have you checked to ensure that there are no scripts in the
> > build repo that are invoking xvfb.py directly?
> 
> The only reference I'm seeing is in scripts/slave/isolation/recipes.isolate
>
https://cs.chromium.org/chromium/build/scripts/slave/isolation/recipes.isolat...
> 
> But I think that's in reference to the xvfb.py script in //build (which is no
> longer in use and can be removed??)

Okay. Can you remove that file, then?