Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2521333002:
Notify PW data source of URLs on first register (Closed)
DescriptionNotify PW data source of URLs on first register
Currently, when we create the Physical Web data source, we do not
populate it with any initial data, which can lead to onLosts occuring
when there has not even been an onFound. This change call onFound for
currently known URLs when first creating the data source.
BUG=667754
Committed: https://crrev.com/faed7fd18b306ebc4410e0bd0ae2422ffcec299e
Cr-Commit-Position: refs/heads/master@{#434712}
Patch Set 1 #Patch Set 2 : update message #
Total comments: 2
Patch Set 3 : Check for onboarding status #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Notify PW data source of URLs on first register BUG=667754 ========== to ========== Notify PW data source of URLs on first register Currently, when we create the Physical Web data source, we do not populate it with any initial data, which can lead to onLosts occuring when there has not even been an onFound. This change call onFound for currently known URLs when first creating the data source. BUG=667754 ==========
cco3@chromium.org changed reviewers: + mattreynolds@chromium.org
https://codereview.chromium.org/2521333002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2521333002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:697: nativeOnFound(mNativePhysicalWebDataSourceAndroid, We should use safeNotifyNativeListenersOnFound here so we won't notify in Onboarding mode.
https://codereview.chromium.org/2521333002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2521333002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:697: nativeOnFound(mNativePhysicalWebDataSourceAndroid, On 2016/11/28 18:45:43, mattreynolds wrote: > We should use safeNotifyNativeListenersOnFound here so we won't notify in > Onboarding mode. Done.
cco3@chromium.org changed reviewers: + dfalcantara@chromium.org
Hi Dan, this should be a small one for you to review.
The CQ bit was checked by cco3@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
lgtm
The CQ bit was unchecked by cco3@chromium.org
The CQ bit was checked by cco3@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480361983566020,
"parent_rev": "0a70b02bf89120721d35d793beafcf38946aa5b2", "commit_rev":
"bff1217ae1ae1b69b0679fe8a2f654e5142b1743"}
Message was sent while issue was closed.
Description was changed from ========== Notify PW data source of URLs on first register Currently, when we create the Physical Web data source, we do not populate it with any initial data, which can lead to onLosts occuring when there has not even been an onFound. This change call onFound for currently known URLs when first creating the data source. BUG=667754 ========== to ========== Notify PW data source of URLs on first register Currently, when we create the Physical Web data source, we do not populate it with any initial data, which can lead to onLosts occuring when there has not even been an onFound. This change call onFound for currently known URLs when first creating the data source. BUG=667754 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Notify PW data source of URLs on first register Currently, when we create the Physical Web data source, we do not populate it with any initial data, which can lead to onLosts occuring when there has not even been an onFound. This change call onFound for currently known URLs when first creating the data source. BUG=667754 ========== to ========== Notify PW data source of URLs on first register Currently, when we create the Physical Web data source, we do not populate it with any initial data, which can lead to onLosts occuring when there has not even been an onFound. This change call onFound for currently known URLs when first creating the data source. BUG=667754 Committed: https://crrev.com/faed7fd18b306ebc4410e0bd0ae2422ffcec299e Cr-Commit-Position: refs/heads/master@{#434712} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/faed7fd18b306ebc4410e0bd0ae2422ffcec299e Cr-Commit-Position: refs/heads/master@{#434712} |
