Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2521323003: Don't pass --print_snapshot_sizes in product mode (Closed)

Created:
4 years ago by Cutch
Modified:
4 years ago
Reviewers:
tvolkert, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't pass --print_snapshot_sizes in product mode BUG= Committed: https://github.com/dart-lang/sdk/commit/ea94a5dcb0be8af3a3ead5d4be0813e55bd8920e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Cutch
4 years ago (2016-11-22 22:46:59 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as ea94a5dcb0be8af3a3ead5d4be0813e55bd8920e (presubmit successful).
4 years ago (2016-11-22 22:47:11 UTC) #5
tvolkert
lgtm
4 years ago (2016-11-22 22:47:17 UTC) #7
rmacnak
4 years ago (2016-11-22 22:50:27 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698