Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: ios/chrome/browser/net/image_fetcher/image_fetcher.mm

Issue 2521253002: Move ImageFetcher to its own target. (Closed)
Patch Set: Reviewable Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/net/image_fetcher/image_fetcher.mm
diff --git a/ios/chrome/browser/net/image_fetcher.mm b/ios/chrome/browser/net/image_fetcher/image_fetcher.mm
similarity index 83%
rename from ios/chrome/browser/net/image_fetcher.mm
rename to ios/chrome/browser/net/image_fetcher/image_fetcher.mm
index f8bc5d1d08dbc180dcd8b5baf069bce8b9f521b4..53a87e0c4acfeadc6fa0710b0faf1a71ea67c55e 100644
--- a/ios/chrome/browser/net/image_fetcher.mm
+++ b/ios/chrome/browser/net/image_fetcher/image_fetcher.mm
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import "ios/chrome/browser/net/image_fetcher.h"
+#import "ios/chrome/browser/net/image_fetcher/image_fetcher.h"
#import <Foundation/Foundation.h>
#include <stddef.h>
@@ -38,6 +38,7 @@ class WebpDecoderDelegate : public webp_transcode::WebpDecoder::Delegate {
DCHECK(decoded_image_);
[decoded_image_ appendData:data];
}
+
private:
~WebpDecoderDelegate() override {}
base::scoped_nsobject<NSMutableData> decoded_image_;
@@ -85,19 +86,19 @@ void ImageFetcher::StartDownload(
net::URLFetcher* fetcher =
net::URLFetcher::Create(url, net::URLFetcher::GET, this).release();
downloads_in_progress_[fetcher] = [callback copy];
- fetcher->SetLoadFlags(
- net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES |
- net::LOAD_DO_NOT_SEND_AUTH_DATA);
+ fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
+ net::LOAD_DO_NOT_SAVE_COOKIES |
+ net::LOAD_DO_NOT_SEND_AUTH_DATA);
fetcher->SetRequestContext(request_context_getter_.get());
fetcher->SetReferrer(referrer);
fetcher->SetReferrerPolicy(referrer_policy);
fetcher->Start();
}
-void ImageFetcher::StartDownload(
- const GURL& url, ImageFetchedCallback callback) {
- ImageFetcher::StartDownload(
- url, callback, std::string(), net::URLRequest::NEVER_CLEAR_REFERRER);
+void ImageFetcher::StartDownload(const GURL& url,
+ ImageFetchedCallback callback) {
+ ImageFetcher::StartDownload(url, callback, std::string(),
+ net::URLRequest::NEVER_CLEAR_REFERRER);
}
// Delegate callback that is called when URLFetcher completes. If the image
@@ -124,8 +125,8 @@ void ImageFetcher::OnURLFetchComplete(const net::URLFetcher* fetcher) {
// code has no meaning, because there is no actual server (data is encoded
// directly in the URL). In that case, set the response code to 200 (OK).
const GURL& original_url = fetcher->GetOriginalURL();
- const int http_response_code = original_url.SchemeIs("data") ?
- 200 : fetcher->GetResponseCode();
+ const int http_response_code =
+ original_url.SchemeIs("data") ? 200 : fetcher->GetResponseCode();
if (http_response_code != 200) {
(callback.get())(original_url, http_response_code, nil);
return;
@@ -146,14 +147,10 @@ void ImageFetcher::OnURLFetchComplete(const net::URLFetcher* fetcher) {
std::string mime_type;
fetcher->GetResponseHeaders()->GetMimeType(&mime_type);
if (mime_type == kWEBPMimeType) {
- base::PostTaskAndReplyWithResult(task_runner_.get(),
- FROM_HERE,
- base::Bind(&DecodeWebpImage, data),
- base::Bind(&ImageFetcher::RunCallback,
- weak_factory_.GetWeakPtr(),
- callback,
- original_url,
- http_response_code));
+ base::PostTaskAndReplyWithResult(
+ task_runner_.get(), FROM_HERE, base::Bind(&DecodeWebpImage, data),
+ base::Bind(&ImageFetcher::RunCallback, weak_factory_.GetWeakPtr(),
+ callback, original_url, http_response_code));
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698