Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: ios/chrome/browser/net/BUILD.gn

Issue 2521253002: Move ImageFetcher to its own target. (Closed)
Patch Set: Split target Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/suggestions/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("net") { 5 source_set("net") {
6 sources = [ 6 sources = [
7 "chrome_cookie_store_ios_client.h", 7 "chrome_cookie_store_ios_client.h",
8 "chrome_cookie_store_ios_client.mm", 8 "chrome_cookie_store_ios_client.mm",
9 "connection_type_observer_bridge.h", 9 "connection_type_observer_bridge.h",
10 "connection_type_observer_bridge.mm", 10 "connection_type_observer_bridge.mm",
11 "cookie_util.h", 11 "cookie_util.h",
12 "cookie_util.mm", 12 "cookie_util.mm",
13 "crl_set_fetcher.cc", 13 "crl_set_fetcher.cc",
14 "crl_set_fetcher.h", 14 "crl_set_fetcher.h",
15 "http_server_properties_manager_factory.cc", 15 "http_server_properties_manager_factory.cc",
16 "http_server_properties_manager_factory.h", 16 "http_server_properties_manager_factory.h",
17 "image_fetcher.h",
18 "image_fetcher.mm",
19 "ios_chrome_http_user_agent_settings.h", 17 "ios_chrome_http_user_agent_settings.h",
20 "ios_chrome_http_user_agent_settings.mm", 18 "ios_chrome_http_user_agent_settings.mm",
21 "ios_chrome_network_delegate.cc", 19 "ios_chrome_network_delegate.cc",
22 "ios_chrome_network_delegate.h", 20 "ios_chrome_network_delegate.h",
23 "ios_chrome_url_request_context_getter.cc", 21 "ios_chrome_url_request_context_getter.cc",
24 "ios_chrome_url_request_context_getter.h", 22 "ios_chrome_url_request_context_getter.h",
25 "metrics_network_client.h", 23 "metrics_network_client.h",
26 "metrics_network_client.mm", 24 "metrics_network_client.mm",
27 "metrics_network_client_manager.h", 25 "metrics_network_client_manager.h",
28 "metrics_network_client_manager.mm", 26 "metrics_network_client_manager.mm",
29 "net_types.h", 27 "net_types.h",
30 "proxy_service_factory.cc", 28 "proxy_service_factory.cc",
31 "proxy_service_factory.h", 29 "proxy_service_factory.h",
32 "retryable_url_fetcher.h", 30 "retryable_url_fetcher.h",
33 "retryable_url_fetcher.mm", 31 "retryable_url_fetcher.mm",
34 ] 32 ]
35 deps = [ 33 deps = [
36 "//base", 34 "//base",
37 "//components/component_updater", 35 "//components/component_updater",
38 "//components/content_settings/core/browser", 36 "//components/content_settings/core/browser",
39 "//components/pref_registry", 37 "//components/pref_registry",
40 "//components/prefs", 38 "//components/prefs",
41 "//components/proxy_config", 39 "//components/proxy_config",
42 "//components/update_client", 40 "//components/update_client",
43 "//ios/chrome/browser", 41 "//ios/chrome/browser",
44 "//ios/chrome/browser/browser_state", 42 "//ios/chrome/browser/browser_state",
45 "//ios/chrome/browser/browsing_data", 43 "//ios/chrome/browser/browsing_data",
46 "//ios/chrome/browser/webp_transcode",
47 "//ios/net", 44 "//ios/net",
48 "//ios/web", 45 "//ios/web",
49 "//net", 46 "//net",
50 "//net:extras", 47 "//net:extras",
51 "//url", 48 "//url",
52 ] 49 ]
50 public_deps = [
51 ":image_fetcher",
sdefresne 2016/11/22 14:38:19 Can you add a TODO to remove this public_deps (or
gambard 2016/11/22 14:44:13 Done.
52 ]
53 allow_circular_includes_from = [ 53 allow_circular_includes_from = [
54 "//ios/chrome/browser", 54 "//ios/chrome/browser",
55 "//ios/chrome/browser/browser_state", 55 "//ios/chrome/browser/browser_state",
56 ] 56 ]
57 } 57 }
58 58
59 source_set("image_fetcher") {
60 sources = [
61 "image_fetcher.h",
62 "image_fetcher.mm",
63 ]
64 deps = [
65 "//base",
66 "//ios/chrome/browser/webp_transcode",
67 "//ios/web",
68 "//net",
69 ]
70 }
71
59 source_set("test_support") { 72 source_set("test_support") {
60 testonly = true 73 testonly = true
61 sources = [ 74 sources = [
62 "mock_image_fetcher.h", 75 "mock_image_fetcher.h",
63 "mock_image_fetcher.mm", 76 "mock_image_fetcher.mm",
64 ] 77 ]
65 deps = [ 78 deps = [
66 ":net", 79 ":image_fetcher",
67 "//testing/gmock", 80 "//testing/gmock",
68 ] 81 ]
69 } 82 }
70 83
71 source_set("unit_tests") { 84 source_set("unit_tests") {
72 testonly = true 85 testonly = true
73 sources = [ 86 sources = [
74 "cookie_util_unittest.mm", 87 "cookie_util_unittest.mm",
75 "image_fetcher_unittest.mm", 88 "image_fetcher_unittest.mm",
76 "metrics_network_client_unittest.mm", 89 "metrics_network_client_unittest.mm",
77 "retryable_url_fetcher_unittest.mm", 90 "retryable_url_fetcher_unittest.mm",
78 ] 91 ]
79 deps = [ 92 deps = [
93 ":image_fetcher",
80 ":net", 94 ":net",
81 "//base", 95 "//base",
82 "//base/test:test_support", 96 "//base/test:test_support",
83 "//ios/web:test_support", 97 "//ios/web:test_support",
84 "//net", 98 "//net",
85 "//net:test_support", 99 "//net:test_support",
86 "//testing/gtest", 100 "//testing/gtest",
87 ] 101 ]
88 } 102 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/browser/suggestions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698