Move ImageFetcher to its own target.

ios/chrome/browser/net/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 source_set("net") {
   sources = [
     "chrome_cookie_store_ios_client.h",
     "chrome_cookie_store_ios_client.mm",
     "connection_type_observer_bridge.h",
     "connection_type_observer_bridge.mm",
     "cookie_util.h",
     "cookie_util.mm",
     "crl_set_fetcher.cc",
     "crl_set_fetcher.h",
     "http_server_properties_manager_factory.cc",
     "http_server_properties_manager_factory.h",
     "image_fetcher.h",

[sdefresne, 2016/11/22 14:03:52]

You also want to move image_fetcher.h to the "image_fetcher" target (see comment
below first).

[gambard, 2016/11/22 14:25:11]

Done.

-    "image_fetcher.mm",
     "ios_chrome_http_user_agent_settings.h",
     "ios_chrome_http_user_agent_settings.mm",
     "ios_chrome_network_delegate.cc",
     "ios_chrome_network_delegate.h",
     "ios_chrome_url_request_context_getter.cc",
     "ios_chrome_url_request_context_getter.h",
     "metrics_network_client.h",
     "metrics_network_client.mm",
     "metrics_network_client_manager.h",
     "metrics_network_client_manager.mm",
     "net_types.h",
     "proxy_service_factory.cc",
     "proxy_service_factory.h",
     "retryable_url_fetcher.h",
     "retryable_url_fetcher.mm",
   ]
   deps = [
     "//base",
     "//components/component_updater",
     "//components/content_settings/core/browser",
     "//components/pref_registry",
     "//components/prefs",
     "//components/proxy_config",
     "//components/update_client",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
     "//ios/chrome/browser/browsing_data",
+    "//ios/chrome/browser/net/image_fetcher",

[sdefresne, 2016/11/22 14:03:52]

You don't have to move the files, just create a target named "image_fetcher" in
the current BUILD.gn file, and the dependency will be on
"//ios/chrome/browser/net:image_fetcher".

[gambard, 2016/11/22 14:25:12]

Done.

     "//ios/chrome/browser/webp_transcode",
     "//ios/net",
     "//ios/web",
     "//net",
     "//net:extras",
     "//url",
   ]
   allow_circular_includes_from = [
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
   ]
 }
 
 source_set("test_support") {

[sdefresne, 2016/11/22 14:03:52]

I don't think we need to change "test_support" as it does not depends on
anything currently, so there is not much risk of having circular dependency.

[gambard, 2016/11/22 14:25:11]

Done.

   testonly = true
   sources = [
     "mock_image_fetcher.h",
-    "mock_image_fetcher.mm",
   ]
   deps = [
-    ":net",
-    "//testing/gmock",
+    "//ios/chrome/browser/net/image_fetcher:test_support",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
     "cookie_util_unittest.mm",
-    "image_fetcher_unittest.mm",
     "metrics_network_client_unittest.mm",

[sdefresne, 2016/11/22 14:03:52]

We do not need to change "unit_tests" target, as only the test app depends on
it, so no risk of circular dependencies.

[gambard, 2016/11/22 14:25:12]

Done.

     "retryable_url_fetcher_unittest.mm",
   ]
   deps = [
     ":net",
     "//base",
     "//base/test:test_support",
     "//ios/web:test_support",
     "//net",
     "//net:test_support",
     "//testing/gtest",
   ]
 }