Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: components/image_fetcher/ios/raw_image_fetcher_unittest.mm

Issue 2521253002: Move ImageFetcher to its own target. (Closed)
Patch Set: Cleanup Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/net/image_fetcher.h" 5 #import "components/image_fetcher/ios/raw_image_fetcher.h"
6 6
7 #import <UIKit/UIKit.h> 7 #import <UIKit/UIKit.h>
8 8
9 #include "base/ios/ios_util.h" 9 #include "base/ios/ios_util.h"
10 #include "base/mac/scoped_block.h" 10 #include "base/mac/scoped_block.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
14 #include "base/run_loop.h" 14 #include "base/run_loop.h"
15 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
16 #include "base/threading/thread_task_runner_handle.h" 16 #include "base/threading/thread_task_runner_handle.h"
17 #include "build/build_config.h" 17 #include "build/build_config.h"
18 #include "net/http/http_response_headers.h" 18 #include "net/http/http_response_headers.h"
19 #include "net/url_request/test_url_fetcher_factory.h" 19 #include "net/url_request/test_url_fetcher_factory.h"
20 #include "net/url_request/url_request_test_util.h" 20 #include "net/url_request/url_request_test_util.h"
21 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
22 #include "testing/platform_test.h" 22 #include "testing/platform_test.h"
23 23
24 namespace { 24 namespace {
25 25
26 static unsigned char kJPGImage[] = { 26 static unsigned char kJPGImage[] = {
27 255,216,255,224,0,16,74,70,73,70,0,1,1,1,0,72,0,72,0,0,255,254,0,19,67, 27 255, 216, 255, 224, 0, 16, 74, 70, 73, 70, 0, 1, 1, 1, 0,
28 114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80,255,219,0,67, 28 72, 0, 72, 0, 0, 255, 254, 0, 19, 67, 114, 101, 97, 116, 101,
29 0,5,3,4,4,4,3,5,4,4,4,5,5,5,6,7,12,8,7,7,7,7,15,11,11,9,12,17,15,18,18, 29 100, 32, 119, 105, 116, 104, 32, 71, 73, 77, 80, 255, 219, 0, 67,
30 17,15,17,17,19,22,28,23,19,20,26,21,17,17,24,33,24,26,29,29,31,31,31, 30 0, 5, 3, 4, 4, 4, 3, 5, 4, 4, 4, 5, 5, 5, 6,
31 19,23,34,36,34,30,36,28,30,31,30,255,219,0,67,1,5,5,5,7,6,7,14,8,8,14, 31 7, 12, 8, 7, 7, 7, 7, 15, 11, 11, 9, 12, 17, 15, 18,
32 30,20,17,20,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30, 32 18, 17, 15, 17, 17, 19, 22, 28, 23, 19, 20, 26, 21, 17, 17,
33 30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30, 33 24, 33, 24, 26, 29, 29, 31, 31, 31, 19, 23, 34, 36, 34, 30,
34 30,30,30,30,30,30,30,30,255,192,0,17,8,0,1,0,1,3,1,34,0,2,17,1,3,17,1, 34 36, 28, 30, 31, 30, 255, 219, 0, 67, 1, 5, 5, 5, 7, 6,
35 255,196,0,21,0,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,8,255,196,0,20,16,1, 35 7, 14, 8, 8, 14, 30, 20, 17, 20, 30, 30, 30, 30, 30, 30,
36 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,196,0,20,1,1,0,0,0,0,0,0,0,0,0,0, 36 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30,
37 0,0,0,0,0,0,255,196,0,20,17,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,218, 37 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30,
38 0,12,3,1,0,2,17,3,17,0,63,0,178,192,7,255,217 38 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 30, 255,
39 }; 39 192, 0, 17, 8, 0, 1, 0, 1, 3, 1, 34, 0, 2, 17, 1,
40 3, 17, 1, 255, 196, 0, 21, 0, 1, 1, 0, 0, 0, 0, 0,
41 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 255, 196, 0, 20,
42 16, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
43 0, 0, 0, 255, 196, 0, 20, 1, 1, 0, 0, 0, 0, 0, 0,
44 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 196, 0, 20, 17,
45 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
46 0, 0, 255, 218, 0, 12, 3, 1, 0, 2, 17, 3, 17, 0, 63,
47 0, 178, 192, 7, 255, 217};
40 48
41 static unsigned char kPNGImage[] = { 49 static unsigned char kPNGImage[] = {
42 137,80,78,71,13,10,26,10,0,0,0,13,73,72,68,82,0,0,0,1,0,0,0,1,1,0,0,0, 50 137, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68,
43 0,55,110,249,36,0,0,0,2,98,75,71,68,0,1,221,138,19,164,0,0,0,9,112,72, 51 82, 0, 0, 0, 1, 0, 0, 0, 1, 1, 0, 0, 0, 0, 55,
44 89,115,0,0,11,18,0,0,11,18,1,210,221,126,252,0,0,0,9,118,112,65,103,0, 52 110, 249, 36, 0, 0, 0, 2, 98, 75, 71, 68, 0, 1, 221, 138,
45 0,0,1,0,0,0,1,0,199,149,95,237,0,0,0,10,73,68,65,84,8,215,99,104,0,0, 53 19, 164, 0, 0, 0, 9, 112, 72, 89, 115, 0, 0, 11, 18, 0,
46 0,130,0,129,221,67,106,244,0,0,0,25,116,69,88,116,99,111,109,109,101, 54 0, 11, 18, 1, 210, 221, 126, 252, 0, 0, 0, 9, 118, 112, 65,
47 110,116,0,67,114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80, 55 103, 0, 0, 0, 1, 0, 0, 0, 1, 0, 199, 149, 95, 237, 0,
48 231,175,64,203,0,0,0,37,116,69,88,116,100,97,116,101,58,99,114,101,97, 56 0, 0, 10, 73, 68, 65, 84, 8, 215, 99, 104, 0, 0, 0, 130,
49 116,101,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49,54,58,52,54,43, 57 0, 129, 221, 67, 106, 244, 0, 0, 0, 25, 116, 69, 88, 116, 99,
50 48,50,58,48,48,31,248,231,223,0,0,0,37,116,69,88,116,100,97,116,101,58, 58 111, 109, 109, 101, 110, 116, 0, 67, 114, 101, 97, 116, 101, 100, 32,
51 109,111,100,105,102,121,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49, 59 119, 105, 116, 104, 32, 71, 73, 77, 80, 231, 175, 64, 203, 0, 0,
52 54,58,52,54,43,48,50,58,48,48,110,165,95,99,0,0,0,17,116,69,88,116,106, 60 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58, 99, 114, 101, 97,
53 112,101,103,58,99,111,108,111,114,115,112,97,99,101,0,50,44,117,85,159, 61 116, 101, 0, 50, 48, 49, 49, 45, 48, 54, 45, 50, 50, 84, 49,
54 0,0,0,32,116,69,88,116,106,112,101,103,58,115,97,109,112,108,105,110, 62 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58, 48, 48, 31, 248,
55 103,45,102,97,99,116,111,114,0,50,120,50,44,49,120,49,44,49,120,49,73, 63 231, 223, 0, 0, 0, 37, 116, 69, 88, 116, 100, 97, 116, 101, 58,
56 250,166,180,0,0,0,0,73,69,78,68,174,66,96,130 64 109, 111, 100, 105, 102, 121, 0, 50, 48, 49, 49, 45, 48, 54, 45,
57 }; 65 50, 50, 84, 49, 54, 58, 49, 54, 58, 52, 54, 43, 48, 50, 58,
66 48, 48, 110, 165, 95, 99, 0, 0, 0, 17, 116, 69, 88, 116, 106,
67 112, 101, 103, 58, 99, 111, 108, 111, 114, 115, 112, 97, 99, 101, 0,
68 50, 44, 117, 85, 159, 0, 0, 0, 32, 116, 69, 88, 116, 106, 112,
69 101, 103, 58, 115, 97, 109, 112, 108, 105, 110, 103, 45, 102, 97, 99,
70 116, 111, 114, 0, 50, 120, 50, 44, 49, 120, 49, 44, 49, 120, 49,
71 73, 250, 166, 180, 0, 0, 0, 0, 73, 69, 78, 68, 174, 66, 96,
72 130};
58 73
59 static unsigned char kWEBPImage[] = { 74 static unsigned char kWEBPImage[] = {
60 82,73,70,70,74,0,0,0,87,69,66,80,86,80,56,88,10,0,0,0,16,0,0,0,0,0,0,0,0,0, 75 82, 73, 70, 70, 74, 0, 0, 0, 87, 69, 66, 80, 86, 80, 56, 88, 10,
61 65,76,80,72,12,0,0,0,1,7,16,17,253,15,68,68,255,3,0,0,86,80,56,32,24,0,0,0, 76 0, 0, 0, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 65, 76, 80, 72,
62 48,1,0,157,1,42,1,0,1,0,3,0,52,37,164,0,3,112,0,254,251,253,80,0 77 12, 0, 0, 0, 1, 7, 16, 17, 253, 15, 68, 68, 255, 3, 0, 0, 86,
63 }; 78 80, 56, 32, 24, 0, 0, 0, 48, 1, 0, 157, 1, 42, 1, 0, 1, 0,
79 3, 0, 52, 37, 164, 0, 3, 112, 0, 254, 251, 253, 80, 0};
64 80
65 static const char kTestUrl[] = "http://www.img.com"; 81 static const char kTestUrl[] = "http://www.img.com";
66 82
67 static const char kWEBPHeaderResponse[] = 83 static const char kWEBPHeaderResponse[] =
68 "HTTP/1.1 200 OK\0Content-type: image/webp\0\0"; 84 "HTTP/1.1 200 OK\0Content-type: image/webp\0\0";
69 85
70 } // namespace 86 } // namespace
71 87
72 class ImageFetcherTest : public PlatformTest { 88 namespace image_fetcher {
89
90 class RawImageFetcherTest : public PlatformTest {
73 protected: 91 protected:
74 ImageFetcherTest() 92 RawImageFetcherTest()
75 : worker_thread_("TestThread"), 93 : worker_thread_("TestThread"),
76 callback_([^(const GURL& original_url, 94 callback_(
77 int http_response_code, 95 [^(const GURL& original_url, int http_response_code, NSData* data) {
78 NSData * data) { 96 result_ = [UIImage imageWithData:data];
79 result_ = [UIImage imageWithData:data]; 97 called_ = true;
80 called_ = true; 98 } copy]) {
81 } copy]) {
82 worker_thread_.Start(); 99 worker_thread_.Start();
83 100
84 image_fetcher_ = 101 image_fetcher_ =
85 base::MakeUnique<ImageFetcher>(worker_thread_.task_runner()); 102 base::MakeUnique<RawImageFetcher>(worker_thread_.task_runner());
86 image_fetcher_->SetRequestContextGetter( 103 image_fetcher_->SetRequestContextGetter(
87 new net::TestURLRequestContextGetter( 104 new net::TestURLRequestContextGetter(
88 base::ThreadTaskRunnerHandle::Get())); 105 base::ThreadTaskRunnerHandle::Get()));
89 } 106 }
90 107
91 net::TestURLFetcher* SetupFetcher() { 108 net::TestURLFetcher* SetupFetcher() {
92 image_fetcher_->StartDownload(GURL(kTestUrl), callback_); 109 image_fetcher_->StartDownload(GURL(kTestUrl), callback_);
93 EXPECT_EQ(nil, result_); 110 EXPECT_EQ(nil, result_);
94 EXPECT_EQ(false, called_); 111 EXPECT_EQ(false, called_);
95 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0); 112 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
96 DCHECK(fetcher); 113 DCHECK(fetcher);
97 DCHECK(fetcher->delegate()); 114 DCHECK(fetcher->delegate());
98 return fetcher; 115 return fetcher;
99 } 116 }
100 117
101 // Message loop for the main test thread. 118 // Message loop for the main test thread.
102 base::MessageLoop loop_; 119 base::MessageLoop loop_;
103 120
104 // Worker thread used for ImageFetcher's asynchronous work. 121 // Worker thread used for ImageFetcher's asynchronous work.
105 base::Thread worker_thread_; 122 base::Thread worker_thread_;
106 123
107 base::mac::ScopedBlock<ImageFetchedCallback> callback_; 124 base::mac::ScopedBlock<ImageFetchedCallback> callback_;
108 net::TestURLFetcherFactory factory_; 125 net::TestURLFetcherFactory factory_;
109 std::unique_ptr<ImageFetcher> image_fetcher_; 126 std::unique_ptr<RawImageFetcher> image_fetcher_;
110 UIImage* result_ = nil; 127 UIImage* result_ = nil;
111 bool called_ = false; 128 bool called_ = false;
112 129
113 private: 130 private:
114 DISALLOW_COPY_AND_ASSIGN(ImageFetcherTest); 131 DISALLOW_COPY_AND_ASSIGN(RawImageFetcherTest);
115 }; 132 };
116 133
117 TEST_F(ImageFetcherTest, TestError) { 134 TEST_F(RawImageFetcherTest, TestError) {
118 net::TestURLFetcher* fetcher = SetupFetcher(); 135 net::TestURLFetcher* fetcher = SetupFetcher();
119 fetcher->set_response_code(404); 136 fetcher->set_response_code(404);
120 fetcher->delegate()->OnURLFetchComplete(fetcher); 137 fetcher->delegate()->OnURLFetchComplete(fetcher);
121 EXPECT_EQ(nil, result_); 138 EXPECT_EQ(nil, result_);
122 EXPECT_TRUE(called_); 139 EXPECT_TRUE(called_);
123 } 140 }
124 141
125 TEST_F(ImageFetcherTest, TestJpg) { 142 TEST_F(RawImageFetcherTest, TestJpg) {
126 net::TestURLFetcher* fetcher = SetupFetcher(); 143 net::TestURLFetcher* fetcher = SetupFetcher();
127 fetcher->set_response_code(200); 144 fetcher->set_response_code(200);
128 fetcher->SetResponseString(std::string((char*)kJPGImage, sizeof(kJPGImage))); 145 fetcher->SetResponseString(std::string((char*)kJPGImage, sizeof(kJPGImage)));
129 fetcher->delegate()->OnURLFetchComplete(fetcher); 146 fetcher->delegate()->OnURLFetchComplete(fetcher);
130 EXPECT_NE(nil, result_); 147 EXPECT_NE(nil, result_);
131 EXPECT_TRUE(called_); 148 EXPECT_TRUE(called_);
132 } 149 }
133 150
134 TEST_F(ImageFetcherTest, TestPng) { 151 TEST_F(RawImageFetcherTest, TestPng) {
135 net::TestURLFetcher* fetcher = SetupFetcher(); 152 net::TestURLFetcher* fetcher = SetupFetcher();
136 fetcher->set_response_code(200); 153 fetcher->set_response_code(200);
137 fetcher->SetResponseString(std::string((char*)kPNGImage, sizeof(kPNGImage))); 154 fetcher->SetResponseString(std::string((char*)kPNGImage, sizeof(kPNGImage)));
138 fetcher->delegate()->OnURLFetchComplete(fetcher); 155 fetcher->delegate()->OnURLFetchComplete(fetcher);
139 EXPECT_NE(nil, result_); 156 EXPECT_NE(nil, result_);
140 EXPECT_TRUE(called_); 157 EXPECT_TRUE(called_);
141 } 158 }
142 159
143 TEST_F(ImageFetcherTest, TestGoodWebP) { 160 TEST_F(RawImageFetcherTest, TestGoodWebP) {
144 // TODO(droger): This test fails on iOS 9 x64 devices. http://crbug.com/523235 161 // TODO(droger): This test fails on iOS 9 x64 devices. http://crbug.com/523235
145 #if defined(OS_IOS) && defined(ARCH_CPU_ARM64) && !TARGET_IPHONE_SIMULATOR 162 #if defined(OS_IOS) && defined(ARCH_CPU_ARM64) && !TARGET_IPHONE_SIMULATOR
146 if (base::ios::IsRunningOnIOS9OrLater()) 163 if (base::ios::IsRunningOnIOS9OrLater())
147 return; 164 return;
148 #endif 165 #endif
149 net::TestURLFetcher* fetcher = SetupFetcher(); 166 net::TestURLFetcher* fetcher = SetupFetcher();
150 fetcher->set_response_code(200); 167 fetcher->set_response_code(200);
151 fetcher->SetResponseString( 168 fetcher->SetResponseString(
152 std::string((char*)kWEBPImage, sizeof(kWEBPImage))); 169 std::string((char*)kWEBPImage, sizeof(kWEBPImage)));
153 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( 170 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
154 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse)))); 171 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
155 fetcher->set_response_headers(headers); 172 fetcher->set_response_headers(headers);
156 fetcher->delegate()->OnURLFetchComplete(fetcher); 173 fetcher->delegate()->OnURLFetchComplete(fetcher);
157 worker_thread_.FlushForTesting(); 174 worker_thread_.FlushForTesting();
158 base::RunLoop().RunUntilIdle(); 175 base::RunLoop().RunUntilIdle();
159 EXPECT_NE(nil, result_); 176 EXPECT_NE(nil, result_);
160 EXPECT_TRUE(called_); 177 EXPECT_TRUE(called_);
161 } 178 }
162 179
163 TEST_F(ImageFetcherTest, TestBadWebP) { 180 TEST_F(RawImageFetcherTest, TestBadWebP) {
164 net::TestURLFetcher* fetcher = SetupFetcher(); 181 net::TestURLFetcher* fetcher = SetupFetcher();
165 fetcher->set_response_code(200); 182 fetcher->set_response_code(200);
166 fetcher->SetResponseString("This is not a valid WebP image"); 183 fetcher->SetResponseString("This is not a valid WebP image");
167 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( 184 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
168 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse)))); 185 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
169 fetcher->set_response_headers(headers); 186 fetcher->set_response_headers(headers);
170 fetcher->delegate()->OnURLFetchComplete(fetcher); 187 fetcher->delegate()->OnURLFetchComplete(fetcher);
171 worker_thread_.FlushForTesting(); 188 worker_thread_.FlushForTesting();
172 base::RunLoop().RunUntilIdle(); 189 base::RunLoop().RunUntilIdle();
173 EXPECT_EQ(nil, result_); 190 EXPECT_EQ(nil, result_);
174 EXPECT_TRUE(called_); 191 EXPECT_TRUE(called_);
175 } 192 }
176 193
177 TEST_F(ImageFetcherTest, DeleteDuringWebPDecoding) { 194 TEST_F(RawImageFetcherTest, DeleteDuringWebPDecoding) {
178 net::TestURLFetcher* fetcher = SetupFetcher(); 195 net::TestURLFetcher* fetcher = SetupFetcher();
179 fetcher->set_response_code(200); 196 fetcher->set_response_code(200);
180 fetcher->SetResponseString( 197 fetcher->SetResponseString(
181 std::string((char*)kWEBPImage, sizeof(kWEBPImage))); 198 std::string((char*)kWEBPImage, sizeof(kWEBPImage)));
182 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( 199 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
183 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse)))); 200 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
184 fetcher->set_response_headers(headers); 201 fetcher->set_response_headers(headers);
185 fetcher->delegate()->OnURLFetchComplete(fetcher); 202 fetcher->delegate()->OnURLFetchComplete(fetcher);
186 // Delete the image fetcher, and check that the callback is not called. 203 // Delete the image fetcher, and check that the callback is not called.
187 image_fetcher_.reset(); 204 image_fetcher_.reset();
188 worker_thread_.FlushForTesting(); 205 worker_thread_.FlushForTesting();
189 base::RunLoop().RunUntilIdle(); 206 base::RunLoop().RunUntilIdle();
190 EXPECT_EQ(nil, result_); 207 EXPECT_EQ(nil, result_);
191 EXPECT_FALSE(called_); 208 EXPECT_FALSE(called_);
192 } 209 }
193 210
194 TEST_F(ImageFetcherTest, TestCallbacksNotCalledDuringDeletion) { 211 TEST_F(RawImageFetcherTest, TestCallbacksNotCalledDuringDeletion) {
195 image_fetcher_->StartDownload(GURL(kTestUrl), callback_); 212 image_fetcher_->StartDownload(GURL(kTestUrl), callback_);
196 image_fetcher_.reset(); 213 image_fetcher_.reset();
197 EXPECT_FALSE(called_); 214 EXPECT_FALSE(called_);
198 } 215 }
199 216
217 } // namespace image_fetcher
OLDNEW
« no previous file with comments | « components/image_fetcher/ios/raw_image_fetcher.mm ('k') | components/image_fetcher/ios/webp_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698