Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2521233002: [fullcodegen] Remove exception handling support. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Remove exception handling support. This removes support for try-catch as well as try-finally constructs from the {FullCodeGenerator}. Consequently optimized code containing such constructs must use the {BytecodeGraphBuilder} and can no longer use the {AstGraphBuilder} for graph building. R=jarin@chromium.org BUG=v8:5657 Committed: https://crrev.com/309b77f00db38e4e3f25e5dd25369a303f8d1bc7 Cr-Commit-Position: refs/heads/master@{#41279}

Patch Set 1 #

Patch Set 2 : Also deal with AbstractCode. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1324 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 7 chunks +4 lines, -247 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +0 lines, -53 lines 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M src/frames.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/frames.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M src/full-codegen/full-codegen.h View 7 chunks +1 line, -77 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 9 chunks +6 lines, -263 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M src/isolate.cc View 1 2 2 chunks +7 lines, -21 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Michael Starzinger
Jaro: PTAL. Ross: FYI.
4 years ago (2016-11-23 10:01:02 UTC) #5
Jarin
Bjutifl, so much red! lgtm.
4 years ago (2016-11-23 10:34:54 UTC) #9
rmcilroy
Very nice! LGTM.
4 years ago (2016-11-23 13:37:03 UTC) #10
rmcilroy
Clusterfuzz fix has landed, so we should be good to land this whenever you like.
4 years ago (2016-11-24 18:17:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521233002/40001
4 years ago (2016-11-25 06:24:42 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-25 07:26:01 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-25 07:26:32 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/309b77f00db38e4e3f25e5dd25369a303f8d1bc7
Cr-Commit-Position: refs/heads/master@{#41279}

Powered by Google App Engine
This is Rietveld 408576698